Skip to content

Commit b6724e9

Browse files
authored
Enable tests for MSSQL and Oracle (#1329)
* Re-enable UUIDGeneratorTest for Oracle The latest Vert.x client supports searching for UUID * Re-enable LobTypeTest for MSSQL Not sure when it's been fixed but it works with the current Vert.x client * Update limitations for Db2 in the README
1 parent 024d998 commit b6724e9

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,3 +250,4 @@ At present several minor limitations remain.
250250
supported.
251251
- With Db2:
252252
* [Automatic schema](http://hibernate.org/reactive/documentation/1.1/reference/html_single/#_automatic_schema_export) update and validation is not supported.
253+
* `@Lob` annotation is not supported - See [this issue on the vertx-db2-client](https://github.com/eclipse-vertx/vertx-sql-client/issues/496)

hibernate-reactive-core/src/test/java/org/hibernate/reactive/UUIDGeneratorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626

2727
public class UUIDGeneratorTest extends BaseReactiveTest {
2828

29-
@Rule // Storing UUID doesn't work with DB2, Searching a UUID doesn't work for Oracle
30-
public DatabaseSelectionRule dbRule = DatabaseSelectionRule.skipTestsFor( DB2, ORACLE );
29+
@Rule // Storing UUID doesn't work with DB2
30+
public DatabaseSelectionRule dbRule = DatabaseSelectionRule.skipTestsFor( DB2 );
3131

3232
@Override
3333
protected Collection<Class<?>> annotatedEntities() {

hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/LobTypeTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,14 @@
2626
import io.vertx.ext.unit.TestContext;
2727

2828
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
29-
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.SQLSERVER;
3029

3130
/**
3231
* Test types that we expect to work only on selected DBs.
3332
*/
3433
public class LobTypeTest extends BaseReactiveTest {
3534

3635
@Rule
37-
public DatabaseSelectionRule selectionRule = DatabaseSelectionRule.skipTestsFor( DB2, SQLSERVER );
36+
public DatabaseSelectionRule selectionRule = DatabaseSelectionRule.skipTestsFor( DB2 );
3837

3938
@Override
4039
protected Collection<Class<?>> annotatedEntities() {

0 commit comments

Comments
 (0)