Skip to content

Conversation

@dreab8
Copy link
Member

@dreab8 dreab8 commented Feb 6, 2025

Fix #2055

Copy link
Member

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this test fails for CockroachDB, probably because it always uses temporary tables (just a guess, I haven't actually checked).

I also noticed that we make the same mistake when we need to drop temporary tables. Could you fix this as well, please?
There is also a typo.

Thanks!

@DavideD
Copy link
Member

DavideD commented Feb 6, 2025

@dreab8, could you also remove this log declaration from the interface, please?

When it's used, you can replace it with:

make( Log.class, lookup() ).debugf( "Creating global-temp ID table : %s", getTemporaryTable().getTableExpression() );

@dreab8 dreab8 force-pushed the HREACT-69 branch 2 times, most recently from ff2de4e to d9646ba Compare February 12, 2025 09:44
…ionFactory.close()

PersistentTemporaryTable dropping is obtained setting PersistentTableStrategy.DROP_ID_TABLES to true
@dreab8 dreab8 force-pushed the HREACT-69 branch 2 times, most recently from 91569b5 to c0cb474 Compare February 12, 2025 09:58
…gy.global_temporary.create_tables to false has no effect
@DavideD
Copy link
Member

DavideD commented Feb 13, 2025

@dreab8, I refactored the test class, could you have a look and let me know what you think? Thanks
The new PR is here: #2109

@DavideD DavideD closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting hibernate.query.mutation_strategy.global_temporary.create_tables to false has no effect

3 participants