Skip to content

clean up a method #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

clean up a method #2178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions ...hibernate/reactive/loader/ast/internal/ReactiveSingleIdEntityLoaderProvidedQueryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,18 @@

import java.util.concurrent.CompletionStage;

import org.hibernate.FlushMode;
import org.hibernate.LockOptions;
import org.hibernate.engine.spi.SharedSessionContractImplementor;
import org.hibernate.internal.util.collections.ArrayHelper;
import org.hibernate.metamodel.mapping.EntityMappingType;
import org.hibernate.query.Query;
import org.hibernate.query.QueryFlushMode;
import org.hibernate.query.named.NamedQueryMemento;
import org.hibernate.query.spi.QueryImplementor;
import org.hibernate.reactive.loader.ast.spi.ReactiveSingleIdEntityLoader;
import org.hibernate.reactive.query.ReactiveSelectionQuery;

import jakarta.persistence.Parameter;
import org.hibernate.type.descriptor.java.JavaType;

import static org.hibernate.reactive.util.impl.CompletionStages.completedFuture;

Expand All @@ -30,9 +31,9 @@ public class ReactiveSingleIdEntityLoaderProvidedQueryImpl<T> implements Reactiv
private static final CompletionStage<Object[]> EMPTY_ARRAY_STAGE = completedFuture( ArrayHelper.EMPTY_OBJECT_ARRAY );

private final EntityMappingType entityDescriptor;
private final NamedQueryMemento namedQueryMemento;
private final NamedQueryMemento<T> namedQueryMemento;

public ReactiveSingleIdEntityLoaderProvidedQueryImpl(EntityMappingType entityDescriptor, NamedQueryMemento namedQueryMemento) {
public ReactiveSingleIdEntityLoaderProvidedQueryImpl(EntityMappingType entityDescriptor, NamedQueryMemento<T> namedQueryMemento) {
this.entityDescriptor = entityDescriptor;
this.namedQueryMemento = namedQueryMemento;
}
Expand All @@ -42,17 +43,13 @@ public EntityMappingType getLoadable() {
return entityDescriptor;
}

@Override
@Override @SuppressWarnings("unchecked")
public CompletionStage<T> load(Object pkValue, LockOptions lockOptions, Boolean readOnly, SharedSessionContractImplementor session) {
// noinspection unchecked
final QueryImplementor<T> query = namedQueryMemento
.toQuery( session, entityDescriptor.getMappedJavaType().getJavaTypeClass() );

//noinspection unchecked
final JavaType<T> mappedJavaType = (JavaType<T>) entityDescriptor.getMappedJavaType();
final Query<T> query = namedQueryMemento.toQuery( session, mappedJavaType.getJavaTypeClass() );
query.setParameter( (Parameter<Object>) query.getParameters().iterator().next(), pkValue );
query.setHibernateFlushMode( FlushMode.MANUAL );

return ( (ReactiveSelectionQuery) query ).reactiveUnique();
query.setQueryFlushMode( QueryFlushMode.NO_FLUSH );
return ( (ReactiveSelectionQuery<T>) query ).reactiveUnique();
}

@Override
Expand Down
Loading