Skip to content

Upgrade Hibernate ORM to to 7.0.0.CR2 #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Upgrade Hibernate ORM to to 7.0.0.CR2 #2253

merged 1 commit into from
May 14, 2025
+161 −156

Conversation

@gavinking
Copy link
Member

@gavinking gavinking commented May 14, 2025 •
edited by DavideD
Loading

adapt to changes to setParameter() signature

Fix #2251

@gavinking
update to 7.0.0.CR2
8b3c40d 
adapt to changes to setParameter() signature
@gavinking gavinking changed the title update to 7.0.0.CR2 [#2251] update to 7.0.0.CR2 May 14, 2025
@DavideD DavideD changed the title [#2251] update to 7.0.0.CR2 Upgrade Hibernate ORM to to 7.0.0.CR2 May 14, 2025
@DavideD
Copy link
Member

DavideD commented May 14, 2025

Could you also add the issue to the commit message, please?

github-advanced-security[bot]
github-advanced-security bot found potential problems May 14, 2025
View reviewed changes
hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/ReactiveQuery.java
* {@link Type}.
*/
<P> ReactiveQuery<R> setParameter(int parameter, P argument, BindableType<P> type);
<P> ReactiveQuery<R> setParameter(int parameter, P argument, Type<P> type);

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ReactiveSelectionQuery.setParameter
Loading
; it is advisable to add an Override annotation.
This method overrides
ReactiveMutationQuery.setParameter
Loading
; it is advisable to add an Override annotation.
hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/ReactiveQuery.java
<P> ReactiveQuery<R> setParameter(QueryParameter<P> parameter, P argument, Class<P> type);

<P> ReactiveQuery<R> setParameter(QueryParameter<P> parameter, P argument, BindableType<P> type);
<P> ReactiveQuery<R> setParameter(QueryParameter<P> parameter, P argument, Type<P> type);

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ReactiveSelectionQuery.setParameter
Loading
; it is advisable to add an Override annotation.
This method overrides
ReactiveMutationQuery.setParameter
Loading
; it is advisable to add an Override annotation.
hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/ReactiveQuery.java
* @return {@code this}, for method chaining
*/
<P> ReactiveQuery<R> setParameterList(String parameter, Collection<? extends P> arguments, BindableType<P> type);
<P> ReactiveQuery<R> setParameterList(String parameter, Collection<? extends P> arguments, Type<P> type);

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ReactiveSelectionQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
This method overrides
ReactiveMutationQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/ReactiveQuery.java
* @return {@code this}, for method chaining
*/
<P> ReactiveQuery<R> setParameterList(String parameter, P[] arguments, BindableType<P> type);
<P> ReactiveQuery<R> setParameterList(String parameter, P[] arguments, Type<P> type);

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ReactiveSelectionQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
This method overrides
ReactiveMutationQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/ReactiveQuery.java
* @return {@code this}, for method chaining
*/
<P> ReactiveQuery<R> setParameterList(int parameter, Collection<? extends P> arguments, BindableType<P> type);
<P> ReactiveQuery<R> setParameterList(int parameter, Collection<? extends P> arguments, Type<P> type);

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ReactiveSelectionQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
This method overrides
ReactiveMutationQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/ReactiveQuery.java
* @return {@code this}, for method chaining
*/
<P> ReactiveQuery<R> setParameterList(int parameter, P[] arguments, BindableType<P> type);
<P> ReactiveQuery<R> setParameterList(int parameter, P[] arguments, Type<P> type);

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ReactiveSelectionQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
This method overrides
ReactiveMutationQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/ReactiveQuery.java
* @return {@code this}, for method chaining
*/
<P> ReactiveQuery<R> setParameterList(QueryParameter<P> parameter, Collection<? extends P> arguments, BindableType<P> type);
<P> ReactiveQuery<R> setParameterList(QueryParameter<P> parameter, Collection<? extends P> arguments, Type<P> type);

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ReactiveSelectionQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
This method overrides
ReactiveMutationQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/ReactiveQuery.java
* @return {@code this}, for method chaining
*/
<P> ReactiveQuery<R> setParameterList(QueryParameter<P> parameter, P[] arguments, BindableType<P> type);
<P> ReactiveQuery<R> setParameterList(QueryParameter<P> parameter, P[] arguments, Type<P> type);

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ReactiveSelectionQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
This method overrides
ReactiveMutationQuery.setParameterList
Loading
; it is advisable to add an Override annotation.
@gavinking
Copy link
Member Author

gavinking commented May 14, 2025

Could you also add the issue to the commit message, please?

The effect of the commit is perfectly well documented in the commit message.

Indeed, there is more information in the commit message than there is in the issue report.

How about we focus on concrete ways to make better software than on this sort of process-obsessed checkbox ticking?

@gavinking
Copy link
Member Author

gavinking commented May 14, 2025

If I'm worrying about issue numbers in commit messages, my attention is on the wrong things, and I'm not focussed on what actually matters. Bureaucracy does harm.

@DavideD
Copy link
Member

DavideD commented May 14, 2025

So melodramatic... but Ok, I'm not going to waist any more time asking this to you.

@gavinking
Copy link
Member Author

gavinking commented May 14, 2025

So melodramatic

Hahah guilty :-)

@gavinking gavinking merged commit 3ec4ff9 into hibernate:main May 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavideD DavideD DavideD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade Hibernate ORM to 7.0.0.CR2

2 participants

@gavinking @DavideD