Skip to content

Remove workaround for HHH-19386 #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Remove workaround for HHH-19386 #2256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ...-reactive-core/src/main/java/org/hibernate/reactive/session/impl/ReactiveSessionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,12 +404,7 @@ public <R> ReactiveQuery<R> createReactiveQuery(TypedQueryReference<R> typedQuer
}
else if ( typedQueryReference instanceof MutationSpecificationImpl<?> specification ) {
final CommonAbstractCriteria query = specification.buildCriteria( getCriteriaBuilder() );
// Workaround for ORM, can be remove when this issue is solved: https://hibernate.atlassian.net/browse/HHH-19386
final Class<R> type =
specification.getResultType() == Void.class
? null
: (Class<R>) specification.getResultType();
return new ReactiveQuerySqmImpl<>( (SqmStatement<R>) query, type, this );
return new ReactiveQuerySqmImpl<>( (SqmStatement<R>) query, (Class<R>) specification.getResultType(), this );
}
else {
@SuppressWarnings("unchecked")
Expand Down
6 changes: 1 addition & 5 deletions ...-core/src/main/java/org/hibernate/reactive/session/impl/ReactiveStatelessSessionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,11 +942,7 @@ public <R> ReactiveQuery<R> createReactiveQuery(TypedQueryReference<R> typedQuer
}
if ( typedQueryReference instanceof MutationSpecificationImpl<?> specification ) {
final CommonAbstractCriteria query = specification.buildCriteria( getCriteriaBuilder() );
// Workaround for ORM, can be remove when this issue is solved: https://hibernate.atlassian.net/browse/HHH-19386
Class<R> type = (Class<R>) specification.getResultType() == Void.class
? null
: (Class<R>) specification.getResultType();
return new ReactiveQuerySqmImpl<>( (SqmStatement<R>) query, type, this );
return new ReactiveQuerySqmImpl<>( (SqmStatement<R>) query, (Class<R>) specification.getResultType(), this );
}
@SuppressWarnings("unchecked")
// this cast is fine because of all our impls of TypedQueryReference return Class<R>
Expand Down
Loading