Test case showing the issue has been resolved #2280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
requested changes
May 28, 2025
Member
DavideD
left a comment
DavideD
left a comment
There was a problem hiding this comment.
Thanks a lot!
It looks good overall, but the test seems simple enough to be included in one of the existing test classes. I left a comment about it.
hibernate-reactive-core/src/test/java/org/hibernate/reactive/HqlSelectNewConstructorTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/HqlSelectNewConstructorTest.java
Outdated
Show resolved
Hide resolved
Member
|
The test suite fails on MS SQL server. I don't think the problem is the test. We probably don't clean something between tests, and the new entities cause a conflict with the existing ones because they have the same name. It's just an assumption, I haven't actually checked |
DavideD
changed the title
dreab8
force-pushed
the
HREACT-108_issue_1793
branch
from
20d3785 to
becfba7
Compare
Test case showing the issue has been resolved
dreab8
force-pushed
the
HREACT-108_issue_1793
branch
from
becfba7 to
24fb18d
Compare
Member
|
Thanks a lot! I want to also remove a few warnings, so I've created a new PR here: #2281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test to show #1793 has been fixed