Skip to content

[4.1] Test '?' operator for PostgreSQL #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

[4.1] Test '?' operator for PostgreSQL #2469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcc292e
[#2012] Refactoring and clean up JsonTypeTest
DavideD Aug 25, 2025
7aea35b
[#2012] Add test for '?' PostgreSQL operator
DavideD Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hibernate-reactive-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ dependencies {
testImplementation(libs.io.vertx.vertx.mssql.client)
testImplementation(libs.io.vertx.vertx.oracle.client)

// Some tests using JSON need a formatter
testRuntimeOnly(libs.com.fasterxml.jackson.core.jackson.databind)

// Metrics
testImplementation(libs.io.vertx.vertx.micrometer.metrics)

Expand Down
70 changes: 49 additions & 21 deletions hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JsonTypeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,15 @@

import java.util.Collection;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.concurrent.CompletionStage;
import java.util.function.Consumer;

import org.hibernate.annotations.JdbcTypeCode;
import org.hibernate.reactive.BaseReactiveTest;
import org.hibernate.reactive.annotations.DisabledFor;
import org.hibernate.reactive.annotations.EnabledFor;
import org.hibernate.type.SqlTypes;

import org.junit.jupiter.api.Test;

Expand All @@ -26,19 +29,18 @@
import jakarta.persistence.Version;

import static java.util.concurrent.TimeUnit.MINUTES;
import static org.assertj.core.api.Assertions.assertThat;
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.MARIA;
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.ORACLE;
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.POSTGRESQL;
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.SQLSERVER;
import static org.hibernate.reactive.util.impl.CompletionStages.loop;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;

/**
* Test types that we expect to work only on selected DBs.
*/
@Timeout(value = 10, timeUnit = MINUTES)

@DisabledFor(value = DB2, reason = "java.sql.SQLException: The object 'HREACT.JSONENTITY' provided is not defined, SQLCODE=-204 SQLSTATE=42704")
@DisabledFor(value = SQLSERVER, reason = "java.lang.IllegalArgumentException: Unsupported value class: class io.vertx.core.json.JsonObject")
@DisabledFor(value = ORACLE, reason = "java.sql.SQLException: ORA-17004: Invalid column type: https://docs.oracle.com/error-help/db/ora-17004/")
Expand All @@ -50,13 +52,37 @@ protected Collection<Class<?>> annotatedEntities() {
return List.of( Basic.class );
}

@Override
public CompletionStage<Void> deleteEntities(Class<?>... types) {
return getSessionFactory()
.withTransaction( s -> loop( types, entityClass -> s
.createSelectionQuery( "from JsonEntity", entityClass )
.getResultList()
.thenCompose( list -> loop( list, entity -> s.remove( entity ) ) ) ) );
@Test
@EnabledFor(POSTGRESQL)
public void nativeQuestionMarkOperatorForPostgres(VertxTestContext context) {
Basic basic = new Basic();
basic.jsonAsMap = Map.of( "sport", "Cheese Rolling" );

test( context, getMutinySessionFactory()
.withTransaction( s -> s.persist( basic ) )
.chain( () -> getMutinySessionFactory().withTransaction( s -> s
.createNativeQuery( "select id from JsonEntity where jsonAsMap -> 'sport' \\? 'Cheese Rolling'" )
.getSingleResult() )
)
.invoke( result -> assertThat( result ).isEqualTo( basic.id ) )
);
}

@Test
@EnabledFor(POSTGRESQL)
public void nativeQuestionMarkOperatorWithParameterForPostgres(VertxTestContext context) {
Basic basic = new Basic();
basic.jsonAsMap = Map.of( "sport", "Chess boxing" );

test( context, getMutinySessionFactory()
.withTransaction( s -> s.persist( basic ) )
.chain( () -> getMutinySessionFactory().withTransaction( s -> s
.createNativeQuery( "select id from JsonEntity where jsonAsMap -> 'sport' \\? ?" )
.setParameter( 1, "Chess boxing" )
.getSingleResult() )
)
.invoke( result -> assertThat( result ).isEqualTo( basic.id ) )
);
}

@Test
Expand All @@ -79,16 +105,15 @@ public void testNullJsonType(VertxTestContext context) {
* Persist the entity, find it and execute the assertions
*/
private void testField(VertxTestContext context, Basic original, Consumer<Basic> consumer) {
test(
context,
getSessionFactory().withTransaction( (s, t) -> s.persist( original ) )
.thenCompose( v -> openSession() )
.thenCompose( s2 -> s2.find( Basic.class, original.id )
.thenAccept( found -> {
assertNotNull( found );
assertEquals( original, found );
consumer.accept( found );
} ) )
test( context, getSessionFactory()
.withTransaction( s -> s.persist( original ) )
.thenCompose( v -> getSessionFactory().withTransaction( s -> s
.find( Basic.class, original.id ) )
)
.thenAccept( found -> {
assertThat( found ).isEqualTo( original );
consumer.accept( found );
} )
);
}

Expand All @@ -105,6 +130,9 @@ private static class Basic {

private JsonObject jsonObj;

@JdbcTypeCode(SqlTypes.JSON)
Map<String, Object> jsonAsMap;

public Basic() {
}

Expand Down
Loading