Support @IdGeneratorType #2476
Closed
Support @IdGeneratorType #2476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -38,4 +41,18 @@ | |||
| default CompletionStage<Id> generate(ReactiveConnectionSupplier session, Object owner, Object currentValue, EventType eventType) { | |||
| return generate( session, owner ); | |||
| } | |||
|
|
|||
| @Override | |||
| default Id generate( | |||
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
...rnate-reactive-core/src/main/java/org/hibernate/reactive/id/ReactiveIdentifierGenerator.java
Fixed
Show fixed
Hide fixed
...-core/src/main/java/org/hibernate/reactive/id/insert/ReactiveUniqueKeySelectingDelegate.java
Dismissed
Show dismissed
Hide dismissed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutationDelegateIdentityTest.java
Fixed
Show fixed
Hide fixed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutationDelegateIdentityTest.java
Fixed
Show fixed
Hide fixed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutationDelegateIdentityTest.java
Fixed
Show fixed
Hide fixed
DavideD
reviewed
Aug 28, 2025
...e-core/src/main/java/org/hibernate/reactive/id/insert/ReactiveAbstractReturningDelegate.java
Outdated
Show resolved
Hide resolved
...e-core/src/main/java/org/hibernate/reactive/id/insert/ReactiveAbstractReturningDelegate.java
Outdated
Show resolved
Hide resolved
...ain/java/org/hibernate/reactive/generator/values/internal/ReactiveGeneratedValuesHelper.java
Outdated
Show resolved
Hide resolved
dreab8
force-pushed
the
issue#1906_4
branch
3 times, most recently
from
ffe4377 to
7fdf4fe
Compare
| } | ||
|
|
||
| @Override | ||
| default Object generate(SharedSessionContractImplementor session, Object object){ |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
DavideD
reviewed
Sep 1, 2025
hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutationDelegateIdentityTest.java
Show resolved
Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/adaptor/impl/ResultSetAdaptor.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/adaptor/impl/ResultSetAdaptor.java
Outdated
Show resolved
Hide resolved
...e-core/src/main/java/org/hibernate/reactive/id/insert/ReactiveAbstractReturningDelegate.java
Outdated
Show resolved
Hide resolved
...ive-core/src/main/java/org/hibernate/reactive/id/insert/ReactiveInsertReturningDelegate.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/hibernate/reactive/persister/entity/impl/ReactiveIdentityGenerator.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/hibernate/reactive/persister/entity/impl/ReactiveIdentityGenerator.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/SqlClientConnection.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/SqlClientConnection.java
Outdated
Show resolved
Hide resolved
...ive-core/src/main/java/org/hibernate/reactive/id/insert/ReactiveInsertReturningDelegate.java
Show resolved
Hide resolved
gavinking
reviewed
Sep 1, 2025
...ore/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityIdentityInsertAction.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityRegularInsertAction.java
Outdated
Show resolved
Hide resolved
...active-core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityUpdateAction.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Sep 1, 2025
...ive-core/src/main/java/org/hibernate/reactive/id/insert/ReactiveInsertReturningDelegate.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutationDelegateIdentityTest.java
Fixed
Show fixed
Hide fixed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutationDelegateIdentityTest.java
Fixed
Show resolved
Hide resolved
...eactive-core/src/test/java/org/hibernate/reactive/MutationDelegateJoinedInheritanceTest.java
Fixed
Show fixed
Hide fixed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutationDelegateTest.java
Fixed
Show fixed
Hide fixed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutationDelegateTest.java
Fixed
Show resolved
Hide resolved
This commit : - Deprecate GeneratedValuesMutationDelegateAdaptor because no longger used - Introduce ReactiveGetGeneratedKeysDelegate so avoid adapting the SQL String for Mysql and Oracle - Add support for multi value generation for dialects not supporting returning clause - Deprecate ReactiveConnection insertAndSelectIdentifier and insertAndSelectIdentifierAsResultSet methods in favour of methods supporting multi generated value - Implement ReactiveBasicSelectingDelegate for dealing with Identity columns where the dialect requires an additional command execution to retrieve the generated value - Implement ReaCtiveUniqueKeySelectingDelegate that uses a unique key of the inserted entity to locate the newly inserted row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix few issues with
OnExecutionGenerators@DavideD not sure about the changes I made to MutinySessionImpl.java and StageSessionImpl I needed the
PersistenceContextin a couple of tests.Also not sure about the name of this method executeSqlAndSelectGeneratedValuesAsResultSet feel free to propose a better one.