Open
Conversation
dreab8
reviewed
Mar 26, 2025
| @@ -0,0 +1,152 @@ | |||
| package org.hibernate.bugs; | |||
Member
There was a problem hiding this comment.
can you please add
/*
* SPDX-License-Identifier: Apache-2.0
* Copyright Red Hat Inc. and Hibernate Authors
*/
to the class?
Thanks
Author
There was a problem hiding this comment.
I can but actually is this correct? it's a copy paste of HikariCPConnectionProvider which have:
/*
* Hibernate, Relational Persistence for Idiomatic Java
*
* License: GNU Lesser General Public License (LGPL), version 2.1 or later.
* See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.
*/
Also, ideally, if you know of a way to do without hikaricp, it would be even better :) is there some idiomatic way of wrapping the DataSource used in the tests without implementing my own ConnectionProvider for example?
Member
There was a problem hiding this comment.
ok I'll try to figure it out. Thanks again for the reproducer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a reproducer for https://hibernate.atlassian.net/browse/HHH-19280.
The issue is when the
DataSourceused inMyConnectionProvideris wrapped with the OpenTelemetry JDBC instrumenter. I decided to reuse theConnectionProviderimplementation from Hikari just because I didn't know how to do something simpler, but the problem has nothing to do with Hikari.Note the debug logs in the log4j file, executing the test will print:
The reason why we see this and why it's a problem is explained here: https://hibernate.atlassian.net/browse/HHH-19280?focusedCommentId=119939