Skip to content

HBX-3313: Fix file handle leaks that cause test failures on Windows #6247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koentsje merged 1 commit into from
Feb 18, 2026
Merged

HBX-3313: Fix file handle leaks that cause test failures on Windows #6247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/utils/src/main/java/org/hibernate/tools/test/util/FileUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,13 @@ public class FileUtil {

static public String findFirstString(String string, File file) {
String str;
try {
BufferedReader in = new BufferedReader(new FileReader(file) );
try (BufferedReader in = new BufferedReader(new FileReader(file))) {
while ( (str = in.readLine() ) != null ) {
if(str.indexOf(string)>=0) {
break;
}
}
in.close();
}
}
catch (IOException e) {
throw new RuntimeException("trouble with searching in " + file,e);
}
Expand Down
13 changes: 7 additions & 6 deletions test/utils/src/main/java/org/hibernate/tools/test/util/ResourceUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,14 @@ public class ResourceUtil {
public static void createResources(Object test, String[] resources, File resourcesDir) {
try {
for (String resource : resources) {
InputStream inputStream = resolveResourceLocation(test.getClass(), resource);
File resourceFile = new File(resourcesDir, resource);
File parent = resourceFile.getParentFile();
if (!parent.exists()) {
parent.mkdirs();
try (InputStream inputStream = resolveResourceLocation(test.getClass(), resource)) {
File resourceFile = new File(resourcesDir, resource);
File parent = resourceFile.getParentFile();
if (!parent.exists()) {
parent.mkdirs();
}
Files.copy(inputStream, resourceFile.toPath());
}
Files.copy(inputStream, resourceFile.toPath());
}
} catch (IOException e) {
throw new RuntimeException(e);
Expand Down