HV-1628 Remove calls to the deprecated AccessibleObject#isAccessible() method

These calls are useless as we now only call it once per element and the
element can't be already marked as accessible.

Author: gsmet

engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java

@@ -7,7 +7,6 @@
 package org.hibernate.validator.internal.metadata.aggregated;
 
 import java.lang.annotation.ElementType;
-import java.lang.reflect.AccessibleObject;
 import java.lang.reflect.Field;
 import java.lang.reflect.Type;
 import java.security.AccessController;
@@ -85,14 +84,9 @@ public FieldCascadable build() {
 		}
 
 		/**
-		 * Returns an accessible version of the given member. Will be the given member itself in case it is accessible,
-		 * otherwise a copy which is set accessible.
+		 * Returns an accessible copy of the given member.
 		 */
 		private Field getAccessible(Field original) {
-			if ( ( (AccessibleObject) original ).isAccessible() ) {
-				return original;
-			}
-
 			SecurityManager sm = System.getSecurityManager();
 			if ( sm != null ) {
 				sm.checkPermission( HibernateValidatorPermission.ACCESS_PRIVATE_MEMBERS );

engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java

@@ -323,14 +323,9 @@ else if ( constrainedElement.getKind() == ConstrainedElementKind.METHOD ) {
 		}
 
 		/**
-		 * Returns an accessible version of the given member. Will be the given member itself in case it is accessible,
-		 * otherwise a copy which is set accessible.
+		 * Returns an accessible copy of the given member.
 		 */
 		private Method getAccessible(Method original) {
-			if ( original.isAccessible() ) {
-				return original;
-			}
-
 			SecurityManager sm = System.getSecurityManager();
 			if ( sm != null ) {
 				sm.checkPermission( HibernateValidatorPermission.ACCESS_PRIVATE_MEMBERS );

engine/src/main/java/org/hibernate/validator/internal/metadata/location/FieldConstraintLocation.java

@@ -116,14 +116,9 @@ public int hashCode() {
 	}
 
 	/**
-	 * Returns an accessible version of the given member. Will be the given member itself in case it is accessible,
-	 * otherwise a copy which is set accessible.
+	 * Returns an accessible copy of the given member.
 	 */
 	private static Field getAccessible(Field original) {
-		if ( original.isAccessible() ) {
-			return original;
-		}
-
 		SecurityManager sm = System.getSecurityManager();
 		if ( sm != null ) {
 			sm.checkPermission( HibernateValidatorPermission.ACCESS_PRIVATE_MEMBERS );

engine/src/main/java/org/hibernate/validator/internal/metadata/location/GetterConstraintLocation.java

@@ -6,7 +6,6 @@
  */
 package org.hibernate.validator.internal.metadata.location;
 
-import java.lang.reflect.AccessibleObject;
 import java.lang.reflect.Method;
 import java.lang.reflect.Type;
 import java.security.AccessController;
@@ -125,14 +124,9 @@ public int hashCode() {
 	}
 
 	/**
-	 * Returns an accessible version of the given method. Will be the given method itself in case it is accessible,
-	 * otherwise a copy which is set accessible.
+	 * Returns an accessible copy of the given method.
 	 */
 	private static Method getAccessible(Method original) {
-		if ( ( (AccessibleObject) original ).isAccessible() ) {
-			return original;
-		}
-
 		SecurityManager sm = System.getSecurityManager();
 		if ( sm != null ) {
 			sm.checkPermission( HibernateValidatorPermission.ACCESS_PRIVATE_MEMBERS );