Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -384,15 +384,10 @@ public MethodValidationConfiguration getMethodValidationConfiguration() {

@Override
public final DefaultConstraintMapping createConstraintMapping() {
GetterPropertySelectionStrategy getterPropertySelectionStrategyToUse = null;
if ( getterPropertySelectionStrategy == null ) {
getterPropertySelectionStrategyToUse = new DefaultGetterPropertySelectionStrategy();
}
else {
getterPropertySelectionStrategyToUse = getterPropertySelectionStrategy;
}

return new DefaultConstraintMapping( new JavaBeanHelper( getterPropertySelectionStrategyToUse, defaultPropertyNodeNameProvider ) );
return new DefaultConstraintMapping( new JavaBeanHelper(
getterPropertySelectionStrategy == null ? new DefaultGetterPropertySelectionStrategy() : getterPropertySelectionStrategy,
validationBootstrapParameters.getPropertyNodeNameProvider() == null ? defaultPropertyNodeNameProvider : validationBootstrapParameters.getPropertyNodeNameProvider()
) );
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
*/
package org.hibernate.validator.test.spi.nodenameprovider;

import static org.hibernate.validator.testutil.ConstraintViolationAssert.assertThat;
import static org.hibernate.validator.testutil.ConstraintViolationAssert.violationOf;
import static org.testng.Assert.assertEquals;

import java.lang.annotation.ElementType;
Expand All @@ -23,6 +25,9 @@
import jakarta.validation.constraints.Size;

import org.hibernate.validator.HibernateValidator;
import org.hibernate.validator.HibernateValidatorConfiguration;
import org.hibernate.validator.cfg.ConstraintMapping;
import org.hibernate.validator.cfg.defs.SizeDef;
import org.hibernate.validator.testutil.TestForIssue;

import org.testng.annotations.BeforeMethod;
Expand Down Expand Up @@ -177,6 +182,30 @@ public void hibernateValidatorFallsBackToDefaultPropertyNodeNameProvider() {
assertEquals( violation.getPropertyPath().toString(), "brand.name" );
}

@Test
public void constraintsDefinedProgrammatically() {
HibernateValidatorConfiguration configuration = Validation.byProvider( HibernateValidator.class )
.configure()
.propertyNodeNameProvider( new AnnotationPropertyNodeNameProvider( PropertyName.class ) );
ConstraintMapping constraintMapping = configuration.createConstraintMapping();

constraintMapping
.type( ProgrammaticCar.class )
.field( "brand" )
.constraint( new SizeDef().min( 5 ).max( 50 ) );

ValidatorFactory validatorFactory = configuration
.addMapping( constraintMapping )
.buildValidatorFactory();

Validator val = validatorFactory.getValidator();

assertThat( val.validate( new ProgrammaticCar( INVALID_BRAND_NAME ) ) )
.containsOnlyViolations( violationOf( Size.class )
.withProperty( "car_brand" ) );

}

@Retention(RetentionPolicy.RUNTIME)
@Target({ ElementType.FIELD, ElementType.METHOD })
public @interface PropertyName {
Expand Down Expand Up @@ -237,4 +266,13 @@ public Airplane(Engine engine) {
this.engine = engine;
}
}

private static class ProgrammaticCar {
@PropertyName("car_brand")
public final String brand;

ProgrammaticCar(String brand) {
this.brand = brand;
}
}
}
Loading