HV-2004 Add constraint initialization payload #1587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marko-bekhta
force-pushed
the
feat/HV-2004-add-constraint-initialization-payload
branch
from
b5a14d2 to
c5b8c43
Compare
yrodiere
reviewed
Aug 26, 2025
...ernate/validator/constraintvalidation/HibernateConstraintValidatorInitializationContext.java
Outdated
Show resolved
Hide resolved
marko-bekhta
force-pushed
the
feat/HV-2004-add-constraint-initialization-payload
branch
from
c5b8c43 to
9648588
Compare
marko-bekhta
force-pushed
the
feat/HV-2004-add-constraint-initialization-payload
branch
from
9648588 to
3267cb0
Compare
marko-bekhta
commented
Sep 5, 2025
...src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/PatternValidator.java
Outdated
Show resolved
Hide resolved
...ain/java/org/hibernate/validator/constraintvalidation/HibernateValidatorFactoryObserver.java
Outdated
Show resolved
Hide resolved
yrodiere
reviewed
Sep 5, 2025
...c/main/java/org/hibernate/validator/internal/engine/ValidatorFactoryConfigurationHelper.java
Outdated
Show resolved
Hide resolved
...ain/java/org/hibernate/validator/constraintvalidation/HibernateValidatorFactoryObserver.java
Outdated
Show resolved
Hide resolved
marko-bekhta
force-pushed
the
feat/HV-2004-add-constraint-initialization-payload
branch
3 times, most recently
from
e0a1f71 to
c6d261c
Compare
and use it to cache patterns in the predefined factory Signed-off-by: marko-bekhta <[email protected]>
marko-bekhta
force-pushed
the
feat/HV-2004-add-constraint-initialization-payload
branch
from
c6d261c to
55f0f98
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HV-2004
I didn't want to have some hardcoded cache for patterns within the pattern constraint validator impl itself. Hence I was thinking that leveraging something similar to what we have for validation with payload could work.
initialization payload would be available to any constraints. As for patterns and their caching, limiting it to the predefined scope makes sense as we have all constraints initialized and can clear out the cache.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.