Properly use Redis and Sentinel password#271
Open
akhy wants to merge 4 commits intohibiken:masterfrom
Open
Conversation
Author
|
Updated the deps and removed the workaround. Will still wait a new release tag of hibiken/asynq |
|
I planned to create PR here, just forgot to do so. Thanks for this update. |
Author
|
sillydong
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to follow up with changes from hibiken/asynq#537 from @sillydong
Updated the tests to show the correct expected behavior from above PR. But since the PR has not released yet, I added a temporary workaround in
main.goto make the tests pass.Will remove the workaround and update deps once hibiken/asynq#537 has tag release. @hibiken You might not want to merge this PR until then.