Rework of PL main and combined signals #776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rework and add additional icons for non-standard states * Add mising form values for some of the signals * Add rendering for shunting sign signal (PL-PKP:m)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, having again read the instructions of railway signalling and seeing in situ examples of signals, I had to make a (last I hope) rework of signalling (based similarly on German Hp, Hl and Ks systems). It highly influences the tagging of well majority of signals, but in near future I will make adjustments.
Some of tagging was simplified, since some signals must appear in combined signals (eg. the next semaphore shows "stop")
Minor changes were made to shunting signal (as the sign form didn't render) and missing form of some signals (that forced writing additional line out of template).
Thanks in advance