feat(1670): token create ft missing options#1681
Merged
mmyslblocky merged 23 commits intomainfrom Mar 31, 2026
Merged
Conversation
…ll to create-ft Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
rozekmichal
reviewed
Mar 24, 2026
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
rozekmichal
requested changes
Mar 25, 2026
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
rozekmichal
previously approved these changes
Mar 26, 2026
matevszm
requested changes
Mar 26, 2026
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
rozekmichal
previously approved these changes
Mar 26, 2026
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
matevszm
requested changes
Mar 30, 2026
Contributor
matevszm
left a comment
There was a problem hiding this comment.
a potential solution
export const AutoRenewPeriodSecondsSchema = z
.union([z.string(), z.number()])
.optional()
.transform((val): number | undefined => {
if (val == null || val === '') return undefined;
return typeof val === 'number' ? val : parseAutoRenewPeriodToSeconds(val);
})
.refine(
(sec) => sec == null || (sec >= HEDERA_AUTO_RENEW_PERIOD_MIN && sec <=
HEDERA_AUTO_RENEW_PERIOD_MAX),
{ message: `Auto-renew period must be between ${HEDERA_AUTO_RENEW_PERIOD_MIN} and
${HEDERA_AUTO_RENEW_PERIOD_MAX} seconds (30–92 days inclusive).` }
);
export const ExpirationTimeSchema = z
.coerce.date()
.optional()
.refine(
(d) => !d || (d.getTime() > Date.now() && d.getTime() <= Date.now() + HEDERA_EXPIRATION_TIME_MAX),
{ message: 'Expiration time must be set in 92 days period.' }
);Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
rozekmichal
previously approved these changes
Mar 30, 2026
matevszm
previously approved these changes
Mar 30, 2026
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
piotrswierzy
requested changes
Mar 30, 2026
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
piotrswierzy
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1670