Skip to content

feat(1670): token create ft missing options#1681

Merged
mmyslblocky merged 23 commits intomainfrom
feat/1670-token-create-ft-missing-options
Mar 31, 2026
Merged

feat(1670): token create ft missing options#1681
mmyslblocky merged 23 commits intomainfrom
feat/1670-token-create-ft-missing-options

Conversation

@mmyslblocky
Copy link
Copy Markdown
Contributor

Issue #1670

…ll to create-ft

Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
@mmyslblocky mmyslblocky requested a review from a team as a code owner March 23, 2026 11:31
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Unit Test Results

1 048 tests  +12   1 048 ✅ +12   1m 41s ⏱️ +5s
  109 suites ± 0       0 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 95d2911. ± Comparison against base commit d50e249.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Integration Test Results

37 tests  ±0   35 ✅ ±0   3m 54s ⏱️ +6s
21 suites ±0    2 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 95d2911. ± Comparison against base commit d50e249.

♻️ This comment has been updated with latest results.

Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
rozekmichal
rozekmichal previously approved these changes Mar 26, 2026
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
rozekmichal
rozekmichal previously approved these changes Mar 26, 2026
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Copy link
Copy Markdown
Contributor

@matevszm matevszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a potential solution

  export const AutoRenewPeriodSecondsSchema = z
    .union([z.string(), z.number()])
    .optional()
    .transform((val): number | undefined => {
      if (val == null || val === '') return undefined;
      return typeof val === 'number' ? val : parseAutoRenewPeriodToSeconds(val);
    })
    .refine(
      (sec) => sec == null || (sec >= HEDERA_AUTO_RENEW_PERIOD_MIN && sec <=
  HEDERA_AUTO_RENEW_PERIOD_MAX),
      { message: `Auto-renew period must be between ${HEDERA_AUTO_RENEW_PERIOD_MIN} and
  ${HEDERA_AUTO_RENEW_PERIOD_MAX} seconds (30–92 days inclusive).` }
    );

  export const ExpirationTimeSchema = z
    .coerce.date()
    .optional()
    .refine(
      (d) => !d || (d.getTime() > Date.now() && d.getTime() <= Date.now() + HEDERA_EXPIRATION_TIME_MAX),
      { message: 'Expiration time must be set in 92 days period.' }
    );

Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
rozekmichal
rozekmichal previously approved these changes Mar 30, 2026
matevszm
matevszm previously approved these changes Mar 30, 2026
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>
@mmyslblocky mmyslblocky merged commit fd96442 into main Mar 31, 2026
16 checks passed
@mmyslblocky mmyslblocky deleted the feat/1670-token-create-ft-missing-options branch March 31, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants