Skip to content

feat(1651): Token delete command extend #1723

Merged
matevszm merged 6 commits intomainfrom
feat-1651/token-delete-command
Mar 31, 2026
Merged

feat(1651): Token delete command extend #1723
matevszm merged 6 commits intomainfrom
feat-1651/token-delete-command

Conversation

@matevszm
Copy link
Copy Markdown
Contributor

@matevszm matevszm requested a review from a team as a code owner March 27, 2026 09:46
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Unit Test Results

1 097 tests  +19   1 097 ✅ +19   1m 38s ⏱️ -1s
  113 suites + 1       0 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 54c1446. ± Comparison against base commit be17c4f.

This pull request removes 4 and adds 23 tests. Note that renamed tests count towards both.
tokenDeleteHandler error scenarios bubbles identity resolution errors ‑ tokenDeleteHandler error scenarios bubbles identity resolution errors
tokenDeleteHandler error scenarios throws NotFoundError when token does not exist in state ‑ tokenDeleteHandler error scenarios throws NotFoundError when token does not exist in state
tokenDeleteHandler success scenarios deletes token from state and removes matching aliases ‑ tokenDeleteHandler success scenarios deletes token from state and removes matching aliases
tokenDeleteHandler success scenarios deletes token without removedAliases when no alias points to token ‑ tokenDeleteHandler success scenarios deletes token without removedAliases when no alias points to token
TokenServiceImpl createDeleteTransaction should create delete transaction with correct tokenId ‑ TokenServiceImpl createDeleteTransaction should create delete transaction with correct tokenId
TokenServiceImpl createDeleteTransaction should log debug messages during delete transaction creation ‑ TokenServiceImpl createDeleteTransaction should log debug messages during delete transaction creation
token plugin - batch-delete hook cleans up state when token found - removeToken + aliases removed ‑ token plugin - batch-delete hook cleans up state when token found - removeToken + aliases removed
token plugin - batch-delete hook processes multiple token_delete items ‑ token plugin - batch-delete hook processes multiple token_delete items
token plugin - batch-delete hook returns batch failure message when batch success is false ‑ token plugin - batch-delete hook returns batch failure message when batch success is false
token plugin - batch-delete hook returns success when no token_delete transactions in batch ‑ token plugin - batch-delete hook returns success when no token_delete transactions in batch
token plugin - batch-delete hook skips items with invalid normalizedParams and logs warn ‑ token plugin - batch-delete hook skips items with invalid normalizedParams and logs warn
token plugin - batch-delete hook skips state cleanup when token not in state ‑ token plugin - batch-delete hook skips state cleanup when token not in state
tokenDelete - network delete (stateOnly=false) error scenarios throws NotFoundError when token not found ‑ tokenDelete - network delete (stateOnly=false) error scenarios throws NotFoundError when token not found
tokenDelete - network delete (stateOnly=false) error scenarios throws TransactionError when transaction fails ‑ tokenDelete - network delete (stateOnly=false) error scenarios throws TransactionError when transaction fails
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Integration Test Results

37 tests  ±0   35 ✅ ±0   3m 50s ⏱️ -1s
21 suites ±0    2 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 54c1446. ± Comparison against base commit be17c4f.

♻️ This comment has been updated with latest results.

rozekmichal
rozekmichal previously approved these changes Mar 30, 2026
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
@matevszm matevszm merged commit bcd946c into main Mar 31, 2026
16 checks passed
@matevszm matevszm deleted the feat-1651/token-delete-command branch March 31, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants