Skip to content

feat(1671): Create nft command expansion#1726

Merged
matevszm merged 4 commits intomainfrom
feat-1671/create-nft-command-expansion
Mar 31, 2026
Merged

feat(1671): Create nft command expansion#1726
matevszm merged 4 commits intomainfrom
feat-1671/create-nft-command-expansion

Conversation

@matevszm
Copy link
Copy Markdown
Contributor

@matevszm matevszm requested a review from a team as a code owner March 27, 2026 10:58
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Unit Test Results

1 100 tests  +22   1 100 ✅ +22   1m 43s ⏱️ +3s
  113 suites + 1       0 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit f69e35b. ± Comparison against base commit cdd2810.

This pull request removes 4 and adds 26 tests. Note that renamed tests count towards both.
tokenDeleteHandler error scenarios bubbles identity resolution errors ‑ tokenDeleteHandler error scenarios bubbles identity resolution errors
tokenDeleteHandler error scenarios throws NotFoundError when token does not exist in state ‑ tokenDeleteHandler error scenarios throws NotFoundError when token does not exist in state
tokenDeleteHandler success scenarios deletes token from state and removes matching aliases ‑ tokenDeleteHandler success scenarios deletes token from state and removes matching aliases
tokenDeleteHandler success scenarios deletes token without removedAliases when no alias points to token ‑ tokenDeleteHandler success scenarios deletes token without removedAliases when no alias points to token
TokenServiceImpl createDeleteTransaction should create delete transaction with correct tokenId ‑ TokenServiceImpl createDeleteTransaction should create delete transaction with correct tokenId
TokenServiceImpl createDeleteTransaction should log debug messages during delete transaction creation ‑ TokenServiceImpl createDeleteTransaction should log debug messages during delete transaction creation
token plugin - batch-delete hook cleans up state when token found - removeToken + aliases removed ‑ token plugin - batch-delete hook cleans up state when token found - removeToken + aliases removed
token plugin - batch-delete hook processes multiple token_delete items ‑ token plugin - batch-delete hook processes multiple token_delete items
token plugin - batch-delete hook returns batch failure message when batch success is false ‑ token plugin - batch-delete hook returns batch failure message when batch success is false
token plugin - batch-delete hook returns success when no token_delete transactions in batch ‑ token plugin - batch-delete hook returns success when no token_delete transactions in batch
token plugin - batch-delete hook skips items with invalid normalizedParams and logs warn ‑ token plugin - batch-delete hook skips items with invalid normalizedParams and logs warn
token plugin - batch-delete hook skips state cleanup when token not in state ‑ token plugin - batch-delete hook skips state cleanup when token not in state
tokenCreateNftHandler optional key scenarios should create NFT with all optional keys ‑ tokenCreateNftHandler optional key scenarios should create NFT with all optional keys
tokenCreateNftHandler optional key scenarios should create NFT with lifecycle params ‑ tokenCreateNftHandler optional key scenarios should create NFT with lifecycle params
…

♻️ This comment has been updated with latest results.

@matevszm matevszm force-pushed the feat-1671/create-nft-command-expansion branch from 1027b35 to dcf2d38 Compare March 27, 2026 11:07
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Integration Test Results

37 tests  ±0   35 ✅ ±0   3m 50s ⏱️ ±0s
21 suites ±0    2 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f69e35b. ± Comparison against base commit cdd2810.

♻️ This comment has been updated with latest results.

@matevszm matevszm requested a review from rozekmichal March 30, 2026 12:51
rozekmichal
rozekmichal previously approved these changes Mar 30, 2026
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
@matevszm matevszm force-pushed the feat-1671/create-nft-command-expansion branch from 9bd3bf2 to 39d03b9 Compare March 31, 2026 10:10
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
@matevszm matevszm merged commit 61df21e into main Mar 31, 2026
21 of 22 checks passed
@matevszm matevszm deleted the feat-1671/create-nft-command-expansion branch March 31, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants