fix: resolve quiesceAndThenRestartMixedOps() flakiness#24567
fix: resolve quiesceAndThenRestartMixedOps() flakiness#24567AlexKehayov wants to merge 29 commits intomainfrom
Conversation
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
gkozyryatskyy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @AlexKehayov !
...in/java/com/hedera/services/bdd/suites/regression/system/QuiesceThenMixedOpsRestartTest.java
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #24567 +/- ##
============================================
+ Coverage 78.23% 78.29% +0.06%
+ Complexity 11692 11688 -4
============================================
Files 2490 2486 -4
Lines 95107 94900 -207
Branches 10293 10280 -13
============================================
- Hits 74406 74305 -101
+ Misses 16960 16855 -105
+ Partials 3741 3740 -1 see 19 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Node: HAPI Test (Misc) Results 160 files ±0 3 errors 157 suites ±0 1h 16m 46s ⏱️ - 16m 18s For more details on these parsing errors, see this check. Results for commit 797302a. ± Comparison against base commit bc67352. ♻️ This comment has been updated with latest results. |
…to fix quiescence Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
797302a to
d2df7c6
Compare
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
… 24398-quiescence-follow-up
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
f78b067 to
170aca3
Compare
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Not up to standards ⛔🟢 Coverage
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ 0.00% coverage variation (-1.00%) |
| Diff coverage | ✅ ∅ diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (3d9574f) 94803 77996 82.27% Head commit (583cd04) 94803 (+0) 77994 (-2) 82.27% (0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#24567) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
# Conflicts: # hedera-node/test-clients/build.gradle.kts
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
54942cf to
9f64026
Compare
… quiescence logic
|
| Test | Ticket |
|---|---|
com.hedera.services.bdd.suites.integration.BlockNodeRewardsTests#activeNodeWithOneRegisteredBlockNodeGetsConsensusAndBlockReward |
#24711 (🆕 New) |
Please review the linked tickets and determine if any of the new issues were caused by your changes.
Description:
Follow-up to #24404.
Root Cause:
The original test's log assertion (assertHgcaaLogContains) searched the entire log file and trivially matched a transient startup quiescence event from node boot. It never validated that real sustained quiescence occurred during the test. The rare CI flake was the balance assertion failing due to tight timing margins.
Findings:
Changes:
Fixes #24398