build: update patching rules for mockito#128
Merged
Conversation
Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
Contributor
|
@PavelSBorisov my take on this is to remove the rule. We have done this similarly for other cases in the past. Reasoning:
|
Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
Member
Author
@jjohannes alright then, I've removed the rules altogether. |
jjohannes
approved these changes
Mar 5, 2025
Contributor
|
The "still a bit shaky" test for the JPMS rules is now failing. But that's a problem in the test setup. I will have a look at that. |
This is require, as older versions are pulled in transitively by 'io.github.json-snapshot:json-snapshot' for which we still have a rule. Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Mockito 5.16.0 adds support for java module info and PRs
for the version update are failing tests so I am opening this PR to add preserveExisting() (opted for this approach in order to allow backwards compatibility since I am not a 100% sure that all repos that use mockito are updated to the new version)
Related issue(s):
Fixes #
Notes for reviewer:
Checklist