feat: allow user to pick server that should be started (#4797) [breaking change]#4798
Draft
jasuwienas wants to merge 2 commits intomainfrom
Draft
feat: allow user to pick server that should be started (#4797) [breaking change]#4798jasuwienas wants to merge 2 commits intomainfrom
jasuwienas wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
bd8b822 to
3bb7890
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (45.45%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #4798 +/- ##
==========================================
+ Coverage 95.74% 95.79% +0.04%
==========================================
Files 138 138
Lines 21623 21499 -124
Branches 1734 1727 -7
==========================================
- Hits 20704 20595 -109
+ Misses 896 883 -13
+ Partials 23 21 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ALlow users to choose which server to start (http, ws or both)
Related issue(s)
Fixes #4797
Testing Guide
(default)
or
to start http server only
2. run
to start ws server only (ws server still exposes addditional endpoints in http interface for healthchecks!!!)
3.run
or
to start both servers
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist