Skip to content

Comments

feat: allow user to pick server that should be started (#4797) [breaking change]#4798

Draft
jasuwienas wants to merge 2 commits intomainfrom
4797-allow-users-to-pick-which-server-to-start
Draft

feat: allow user to pick server that should be started (#4797) [breaking change]#4798
jasuwienas wants to merge 2 commits intomainfrom
4797-allow-users-to-pick-which-server-to-start

Conversation

@jasuwienas
Copy link
Contributor

@jasuwienas jasuwienas commented Jan 13, 2026

Description

ALlow users to choose which server to start (http, ws or both)

Related issue(s)

Fixes #4797

Testing Guide

  1. run
npm run start

(default)
or

npm run start:http

to start http server only
2. run

npm run start:ws

to start ws server only (ws server still exposes addditional endpoints in http interface for healthchecks!!!)
3.run

npm run start:ws,http

or

npm run start:http,ws

to start both servers

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
@jasuwienas jasuwienas added this to the 0.75.0 milestone Jan 13, 2026
@jasuwienas jasuwienas self-assigned this Jan 13, 2026
@jasuwienas jasuwienas added the enhancement New feature or request label Jan 13, 2026
@jasuwienas jasuwienas requested review from a team as code owners January 13, 2026 14:42
@jasuwienas jasuwienas requested a review from natanasow January 13, 2026 14:42
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 3bb7890. ± Comparison against base commit 316ecab.

♻️ This comment has been updated with latest results.

@jasuwienas jasuwienas changed the title feat: allow user to pick server that should be started (#4797) feat: allow user to pick server that should be started (#4797) [BREAKING CHANGE] Jan 13, 2026
@jasuwienas jasuwienas changed the title feat: allow user to pick server that should be started (#4797) [BREAKING CHANGE] feat: allow user to pick server that should be started (#4797) [breaking change] Jan 13, 2026
@jasuwienas jasuwienas marked this pull request as draft January 13, 2026 15:36
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
@jasuwienas jasuwienas force-pushed the 4797-allow-users-to-pick-which-server-to-start branch from bd8b822 to 3bb7890 Compare January 14, 2026 14:52
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/ws-server/src/index.ts 0.00% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (45.45%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main    #4798      +/-   ##
==========================================
+ Coverage   95.74%   95.79%   +0.04%     
==========================================
  Files         138      138              
  Lines       21623    21499     -124     
  Branches     1734     1727       -7     
==========================================
- Hits        20704    20595     -109     
+ Misses        896      883      -13     
+ Partials       23       21       -2     
Flag Coverage Δ
config-service 98.87% <100.00%> (+<0.01%) ⬆️
relay 92.74% <ø> (+0.03%) ⬆️
server 88.26% <ø> (ø)
ws-server 97.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/config-service/src/services/globalConfig.ts 100.00% <100.00%> (ø)
packages/ws-server/src/index.ts 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simzzz simzzz modified the milestones: 0.75.0, 0.76.0 Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 Server: 2 protocols Allow users to pick which protocol to start

2 participants