feat: introduce WORKERS_POOL_ENABLED config to optionally disable worker thread pool#5070
Open
quiet-node wants to merge 1 commit intomainfrom
Conversation
Open
4 tasks
…ker thread pool Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
62801a5 to
d8931d9
Compare
quiet-node
commented
Mar 12, 2026
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #5070 +/- ##
==========================================
- Coverage 95.90% 95.89% -0.01%
==========================================
Files 144 145 +1
Lines 24740 24813 +73
Branches 1984 1993 +9
==========================================
+ Hits 23727 23795 +68
- Misses 985 990 +5
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
natanasow
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
WORKERS_POOL_ENABLEDconfiguration flag, allowing operators to optionally disable the worker thread pool (piscina). Key changes:WORKERS_POOL_ENABLEDconfiguration variable inglobalConfig.ts(defaults totrue).WorkersPool.tsto support a "Local Bypass" mode using dynamic imports to load worker logic only when needed.WorkersErrorUtils.tsto provide standardized error serialization and reconstruction across thread boundaries, preventing circular dependencies.blockWorker.tsandcommonWorker.tsto leverage the new error utilities.Related issue(s)
Fixes #4987
Testing Guide
WORKERS_POOL_ENABLED=false.eth_getLogs,eth_getBlockByNumber) and ensure they complete successfully on the main thread.Checklist