Skip to content

docs: update tx pool to reflect RLP hex storage instead of tx hash#5075

Open
bootcodes wants to merge 1 commit intohiero-ledger:mainfrom
bootcodes:5067-doc-update-tx-pool-with-rpc-encoded-data
Open

docs: update tx pool to reflect RLP hex storage instead of tx hash#5075
bootcodes wants to merge 1 commit intohiero-ledger:mainfrom
bootcodes:5067-doc-update-tx-pool-with-rpc-encoded-data

Conversation

@bootcodes
Copy link

@bootcodes bootcodes commented Mar 12, 2026

Description

This PR updates docs/nonce-management-and-tx-pool.md to reflect the actual store values for the transaction pool.
Replaces tx hash by RLP encoded transaction in the following sections :
### Storage backends
and
#### eth_sendRawTransaction

Related issue(s)

Fixes #5067

Testing Guide

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

Signed-off-by: Thomas Boot <thomas.boot@swirldslabs.com>
@quiet-node quiet-node added the documentation Improvements or additions to documentation label Mar 12, 2026
@quiet-node quiet-node added this to the 0.76.0 milestone Mar 12, 2026
@bootcodes bootcodes marked this pull request as ready for review March 12, 2026 16:18
@bootcodes bootcodes requested review from a team as code owners March 12, 2026 16:18
@bootcodes bootcodes requested a review from natanasow March 12, 2026 16:18
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project check has failed because the head coverage (72.99%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (ceba217) and HEAD (a5509da). Click for more details.

HEAD has 20 uploads less than BASE
Flag BASE (ceba217) HEAD (a5509da)
21 5
config-service 1 0
relay 1 0
server 1 0
ws-server 1 0
@@             Coverage Diff             @@
##             main    #5075       +/-   ##
===========================================
- Coverage   95.89%   72.99%   -22.91%     
===========================================
  Files         145      145               
  Lines       24824    24824               
  Branches     1994      836     -1158     
===========================================
- Hits        23806    18120     -5686     
- Misses        990     6688     +5698     
+ Partials       28       16       -12     
Flag Coverage Δ
config-service ?
relay ?
server ?
ws-server ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 86 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update TX pool doc, to reflect RPC encoded data usage

2 participants