docs: update tx pool to reflect RLP hex storage instead of tx hash#5075
Open
bootcodes wants to merge 1 commit intohiero-ledger:mainfrom
Open
docs: update tx pool to reflect RLP hex storage instead of tx hash#5075bootcodes wants to merge 1 commit intohiero-ledger:mainfrom
bootcodes wants to merge 1 commit intohiero-ledger:mainfrom
Conversation
Signed-off-by: Thomas Boot <thomas.boot@swirldslabs.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (72.99%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
@@ Coverage Diff @@
## main #5075 +/- ##
===========================================
- Coverage 95.89% 72.99% -22.91%
===========================================
Files 145 145
Lines 24824 24824
Branches 1994 836 -1158
===========================================
- Hits 23806 18120 -5686
- Misses 990 6688 +5698
+ Partials 28 16 -12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
docs/nonce-management-and-tx-pool.mdto reflect the actual store values for the transaction pool.Replaces
tx hashbyRLP encoded transactionin the following sections :### Storage backendsand
#### eth_sendRawTransactionRelated issue(s)
Fixes #5067
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist