fix: restore multinode mode functionality#1031
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #1031 +/- ##
=======================================
Coverage ? 60.21%
=======================================
Files ? 29
Lines ? 1204
Branches ? 153
=======================================
Hits ? 725
Misses ? 456
Partials ? 23 🚀 New features to boost your workflow:
|
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
01adebb to
aeec8e8
Compare
Nana-EC
left a comment
There was a problem hiding this comment.
Great work. Minor non blocking comments.
I had a PR with similar changes I wanted to push but your changes are focused so let's go with this.
if this works let's get it in and get a new version out and I can circle back with tickets for other things I had in mind.
@georgi-l95 kindly take a look.
|
Bump @isavov and @georgi-l95 |
|
@Nana-EC @georgi-l95 Rereview please 🙏 |
Hey @isavov , nice work. |
Nana-EC
left a comment
There was a problem hiding this comment.
LG
If we can confirm operation then I think we're good to get this in and unblock users for this mode, then iterate as needed
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Nana-EC
left a comment
There was a problem hiding this comment.
LG.
Let's get this in and iterate
georgi-l95
left a comment
There was a problem hiding this comment.
Works, played around by stoping and starting different nodes to see if they catch up or if the mirror node ingests the record files. Everything is working as expected. Well done and thank you @isavov
Description:
Changes introduced in the consensus node version 0.59.0 have resulted in
multinodemode not working. This PR restores the functionality by:config.multinode.txtwith settings compatible with the newer versionsRelated issue(s):
Fixes #1017, Fixes #992
Notes for reviewer:
I did my best to test this PR, but was not able to test it fully. Please test yourself before merging.
Checklist