Skip to content

Conversation

@IvanKavaldzhiev
Copy link
Contributor

@IvanKavaldzhiev IvanKavaldzhiev commented Dec 18, 2025

Description:
This PR enhances the CI/CD to also run tests related to monitor module when helm test is invoked.

Related issue(s):

Fixes #11990

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Kavaldzhiev <[email protected]>
@IvanKavaldzhiev IvanKavaldzhiev self-assigned this Dec 18, 2025
@IvanKavaldzhiev IvanKavaldzhiev added the test Test infrastructure, automated tests required, etc label Dec 18, 2025
@lfdt-bot
Copy link

lfdt-bot commented Dec 18, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Dec 18, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-39.21% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7bf56c9) 27260 25585 93.86%
Head commit (f9fa043) 52750 (+25490) 28828 (+3243) 54.65% (-39.21%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#12643) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@IvanKavaldzhiev IvanKavaldzhiev marked this pull request as ready for review December 19, 2025 14:32
@IvanKavaldzhiev IvanKavaldzhiev requested review from a team as code owners December 19, 2025 14:32
@steven-sheehy steven-sheehy added enhancement Type: New feature monitor Area: Monitoring and dashboard github actions Pull requests that update GitHub Actions code and removed test Test infrastructure, automated tests required, etc labels Dec 19, 2025
@steven-sheehy steven-sheehy added this to the 0.146.0 milestone Dec 19, 2025
Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why acceptance shows the error: unable to get pod logs for mirror-1-rest-test: pods "mirror-1-rest-test" not found?

@IvanKavaldzhiev
Copy link
Contributor Author

Any idea why acceptance shows the error: unable to get pod logs for mirror-1-rest-test: pods "mirror-1-rest-test" not found?

The rest test pod was enabled. I disabled it. However, the same error appear now for monitor-test. I believe the test passes so quick, that the pod shuts down and the logs cannot be fetched. I tried to set a sleep duration, however there is an issue with building solo and the fix currently can't be validated.

@steven-sheehy
Copy link
Contributor

steven-sheehy commented Dec 30, 2025

The unable to get pod logs for error seems to be due to helm/helm#9098. We should revert the sleeps. We can workaround by removing the hook-succeeded from the helm.sh/hook-delete-policy in CI.

Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 7af5171 into main Jan 7, 2026
36 of 39 checks passed
@steven-sheehy steven-sheehy deleted the 11990-test-monitor-in-ci branch January 7, 2026 17:11
ashumahajan pushed a commit to ashumahajan/hiero-mirror-node that referenced this pull request Jan 16, 2026
 This PR enhances the CI/CD to also run tests related to monitor module when helm test is invoked.

---------

Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: New feature github actions Pull requests that update GitHub Actions code monitor Area: Monitoring and dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test monitor in CI

5 participants