-
Notifications
You must be signed in to change notification settings - Fork 138
Enable monitor testing in CI #12643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable monitor testing in CI #12643
Conversation
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
monitor/src/main/java/org/hiero/mirror/monitor/health/ClusterHealthIndicator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
steven-sheehy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why acceptance shows the error: unable to get pod logs for mirror-1-rest-test: pods "mirror-1-rest-test" not found?
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
The rest test pod was enabled. I disabled it. However, the same error appear now for monitor-test. I believe the test passes so quick, that the pod shuts down and the logs cannot be fetched. I tried to set a sleep duration, however there is an issue with building solo and the fix currently can't be validated. |
|
The |
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
xin-hedera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR enhances the CI/CD to also run tests related to monitor module when helm test is invoked. --------- Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Description:
This PR enhances the CI/CD to also run tests related to monitor module when
helm testis invoked.Related issue(s):
Fixes #11990
Notes for reviewer:
Checklist