Conversation
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
17 tasks
gsstoykov
approved these changes
Feb 24, 2026
andrewb1269
approved these changes
Feb 24, 2026
PavelSBorisov
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a chicken-and-egg failure in the three bot workflows (
on-pr,on-commit,on-comment) where the local composite action.github/actions/setup-botcould not beresolved because
pull_request_targetdoes not automatically check out the repository.Key Changes:
.github/actions/setup-bot/composite actionMotivation
The bot workflows use
pull_request_target(andissue_comment) triggers with a writetoken, and deliberately check out only the default branch to avoid running untrusted PR
code. The checkout was encapsulated in a local composite action at
.github/actions/setup-bot/action.yml.However,
pull_request_targetdoes not automatically check out the repository when a jobstarts. GitHub Actions needs the composite action file on disk to even begin executing it,
creating an unresolvable dependency: the action that performs the checkout cannot itself be
loaded without a prior checkout.
This caused every bot workflow run to fail immediately with:
Changes
Workflow Inlining
In each of the three bot workflows, the single
Setup Bot Environmentstep:was replaced with the two steps it contained:
Both action pins (SHA and version comment) are preserved exactly as they were in the
composite action.
Comment Cleanup
The header comment in
on-comment.yamlreferenced the old composite action and wasupdated to reflect the new inline approach.
Composite Action Removal
.github/actions/setup-bot/action.ymlwas deleted since it is no longer referencedby any workflow.
Testing
zxc-test-bot-scripts.yamldoes not referencesetup-bot(it already inlines its own steps).github/actions/setup-botFiles Changed Summary
.github/workflows/on-pr.yaml.github/workflows/on-commit.yaml.github/workflows/on-comment.yaml.github/actions/setup-bot/action.ymlBreaking Changes
None. All workflow triggers, permissions, concurrency groups, and bot script invocations
remain unchanged. The only difference is that the harden-runner and checkout steps are now
defined directly in each workflow instead of being referenced through a composite action.