fix: unify GTest to vcpkg across all platforms#1194
Merged
rwalworth merged 1 commit intohiero-ledger:mainfrom Feb 25, 2026
Merged
Conversation
github-actions
bot
added
the
status: needs review
Contributor
Author
|
@rwalworth @exploreriii Ready for review! |
rwalworth
approved these changes
Feb 25, 2026
Contributor
rwalworth
left a comment
rwalworth
left a comment
There was a problem hiding this comment.
LGTM, thank you @gangulysiddhartha22-cmyk! The changes correctly unify GTest to vcpkg across all platforms and clean up the redundant find_package / include calls in the child CMakeLists files. I'm going to run the workflows now and assuming they pass, I will get this merged!
Congratulations on your first contribution to the Hiero C++ SDK! 🎉 Thank you for taking the time to contribute!
Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
gangulysiddhartha22-cmyk
force-pushed
the
fix/1184-gtest-vcpkg-cleanup
branch
from
00a2c7f to
7f51e89
Compare
rwalworth
removed
the
status: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Makes Google Test (GTest) consistent across all platforms
Related issue(s):
Fixes #1184
Notes for reviewer:
CI will automatically verify
Checklist