fix: added getAccountBalance JsonRpc endpt.#1200
Merged
rwalworth merged 2 commits intohiero-ledger:mainfrom Mar 2, 2026
Merged
fix: added getAccountBalance JsonRpc endpt.#1200rwalworth merged 2 commits intohiero-ledger:mainfrom
rwalworth merged 2 commits intohiero-ledger:mainfrom
Conversation
Signed-off-by: Aditya Arya <arya050411@gmail.com>
github-actions
bot
added
the
status: needs review
Signed-off-by: Aditya Arya <arya050411@gmail.com>
Adityarya11
force-pushed
the
feat/getAccountBalance-jsonRpc#667
branch
from
bd2f337 to
edfd743
Compare
rwalworth
approved these changes
Mar 2, 2026
Contributor
rwalworth
left a comment
rwalworth
left a comment
There was a problem hiding this comment.
Thanks for working on this @Adityarya11! The overall structure looks good - you've got the params, the service function, the registration, and the template instantiation all in the right places.
rwalworth
removed
the
status: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added
GetAccountBalanceJsonRPC endpoint to the sdk to match the TCK server. Test passes successfully.GetAccountBalanceParamsstruct with optionalaccountIdandcontractIdfield and JSON deserializer.getAccountBalancefunction declaration toAccountService.h.getAccountBalanceinAccountService.ccusingAccountBalanceQuery, serializing allAccountBalancefields to the JSON format expected by TCK tests.Related issue(s):
Fixes #667
Notes for reviewer:
Checklist