fix: Fixed typo of lenght to length#1216
Merged
rwalworth merged 1 commit intohiero-ledger:mainfrom Mar 10, 2026
Merged
Conversation
|
Hi @Kubikusik 👋, thank you for submitting this PR! This comment will stay updated as you make changes. PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. ✅ GPG Signature -- All commits have verified GPG signatures. ✅ Merge Conflicts -- No merge conflicts detected. ✅ Issue Link -- Linked to #1214 (assigned to you). 🎉 All checks passed! Your PR is ready for review. |
github-actions
bot
added
the
status: needs revision
Kubikusik
force-pushed
the
FixTypoLengthConstant
branch
from
a703d73 to
9a57c17
Compare
github-actions
bot
added
status: needs review
Signed-off-by: kubikusik <jakubmical@student.agh.edu.pl>
Kubikusik
force-pushed
the
FixTypoLengthConstant
branch
from
9a57c17 to
88d77dd
Compare
rwalworth
approved these changes
Mar 10, 2026
Contributor
rwalworth
left a comment
rwalworth
left a comment
There was a problem hiding this comment.
LGTM, thank you @Kubikusik! The rename covers all five references and the change is exactly what was requested in #1214. Running the workflows now and will merge once they pass!
rwalworth
removed
the
status: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix the spelling mistake in the MAX_ENCRYPTED_KEY_LENGHT constant.
Related issue(s):
Fixes #1214
Notes for reviewer:
This PR resolves the beginner issue to fix misspelling of a constant.
Renames MAX_ENCRYPTED_KEY_LENGHT to MAX_ENCRYPTED_KEY_LENGTH in ASN1ECKey.h
Updates all references to the corrected constant name in ASN1ECPrivateKey.cc, ASN1ECPublicKey.cc, ASN1ED25519PrivateKey.cc, and ASN1ED25519PublicKey.cc
Checklist