Skip to content

feat: Implemented deleteFile Tck endpoint#1221

Merged
rwalworth merged 3 commits intohiero-ledger:mainfrom
Adityarya11:feat/delete-tck-endpt#1215
Mar 11, 2026
Merged

feat: Implemented deleteFile Tck endpoint#1221
rwalworth merged 3 commits intohiero-ledger:mainfrom
Adityarya11:feat/delete-tck-endpt#1215

Conversation

@Adityarya11
Copy link
Copy Markdown
Contributor

Description:
Implements the deleteFile JSON-RPC endpoint for the TCK server to support file deletion compatibility tests.

  • Add deleteFile method to FileService utilizing FileDeleteTransaction
  • Create DeleteFileParams for JSON deserialization and register the endpoint in TckServer

Related issue(s):

Fixes #1215


Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Aditya Arya <arya050411@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 11, 2026

Hey @Adityarya11 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1215 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions bot added the status: needs review The pull request is ready for maintainer review label Mar 11, 2026
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Adityarya11, clean implementation that follows the deleteToken pattern exactly. Merging!

@rwalworth rwalworth merged commit 813c443 into hiero-ledger:main Mar 11, 2026
11 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 11, 2026
@Adityarya11 Adityarya11 deleted the feat/delete-tck-endpt#1215 branch March 11, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Intermediate]: Implement deleteFile TCK endpoint

2 participants