Fix: removeSignature docstring style in Transaction.h#1228
Fix: removeSignature docstring style in Transaction.h#1228rwalworth merged 2 commits intohiero-ledger:mainfrom
Conversation
|
Hey @ak004 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1226 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
5e9c620 to
e27b8db
Compare
|
The commit has now been GPG signed and force-pushed to the branch. |
Signed-off-by: Mascud Muse Hassan <mascuudmusse44@gmail.com>
e27b8db to
d24fd46
Compare
rwalworth
left a comment
There was a problem hiding this comment.
Thanks for the contribution @ak004! The docstring text itself looks great and matches the issue requirements exactly. I found one formatting issue below that needs to be fixed before we can merge - once that's addressed, we'll be good to go. Let me know if you have any questions!
Signed-off-by: Mascud Muse Hassan <mascuudmusse44@gmail.com>
rwalworth
left a comment
There was a problem hiding this comment.
LGTM - the indentation is fixed and everything matches the requirements. Running the workflows now and will get this merged!
Description:
Update the removeSignature docstring in Transaction.h to match the documentation style used throughout the file.
Related issue(s):
Fixes #1226
Notes for reviewer:
This change updates documentation only. No functional code or public API behavior was modified.
Checklist