Skip to content

Refactor: extractSignatureBytes to use stringToByteVector and add tra…#1229

Closed
ak004 wants to merge 1 commit intohiero-ledger:mainfrom
ak004:fix-extractSignatureBytes
Closed

Refactor: extractSignatureBytes to use stringToByteVector and add tra…#1229
ak004 wants to merge 1 commit intohiero-ledger:mainfrom
ak004:fix-extractSignatureBytes

Conversation

@ak004
Copy link
Copy Markdown
Contributor

@ak004 ak004 commented Mar 14, 2026

Description:

Refactor the extractSignatureBytes helper function to use internal::Utilities::stringToByteVector instead of manually converting strings to byte vectors.
Also, add a trailing newline at the end of TransactionUnitTests.cc

  • Use stringToByteVector for consistency
  • Add newline to TransactionUnitTests.cc

Related issue(s):

Fixes #1227

Notes for reviewer:

This is a refactor and formatting change only — no behavior or API changes.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ak004 ak004 requested review from a team as code owners March 14, 2026 08:24
@ak004 ak004 requested a review from gsstoykov March 14, 2026 08:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2026

Hey @ak004 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- Heads up! The following commits don't have a verified GPG signature:

  • 260ed02 Refactor: extractSignatureBytes to use stringToByteVector and add trailing newline

You'll need to sign your commits with GPG (e.g. git commit -S). See the Signing Guide for a step-by-step walkthrough.


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1227 (assigned to you).


All checks must pass before this PR can be reviewed. You've got this!

@github-actions github-actions bot added the status: needs revision A pull request that requires changes before merge label Mar 14, 2026
@ak004 ak004 force-pushed the fix-extractSignatureBytes branch from ce3af81 to 5087500 Compare March 14, 2026 08:32
…iling newline

Signed-off-by: Mascud Muse Hassan <mascuudmusse44@gmail.com>
@ak004 ak004 force-pushed the fix-extractSignatureBytes branch from 5087500 to 260ed02 Compare March 14, 2026 08:44
@ak004 ak004 closed this Mar 14, 2026
@rwalworth rwalworth removed the status: needs revision A pull request that requires changes before merge label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: use stringToByteVector utility in extractSignatureBytes

2 participants