Refactor: extractSignatureBytes to use stringToByteVector and add tra…#1229
Closed
ak004 wants to merge 1 commit intohiero-ledger:mainfrom
Closed
Refactor: extractSignatureBytes to use stringToByteVector and add tra…#1229ak004 wants to merge 1 commit intohiero-ledger:mainfrom
ak004 wants to merge 1 commit intohiero-ledger:mainfrom
Conversation
|
Hey @ak004 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ❌ GPG Signature -- Heads up! The following commits don't have a verified GPG signature:
You'll need to sign your commits with GPG (e.g. ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1227 (assigned to you). ⏳ All checks must pass before this PR can be reviewed. You've got this! |
ce3af81 to
5087500
Compare
…iling newline Signed-off-by: Mascud Muse Hassan <mascuudmusse44@gmail.com>
5087500 to
260ed02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Refactor the
extractSignatureByteshelper function to useinternal::Utilities::stringToByteVectorinstead of manually converting strings to byte vectors.Also, add a trailing newline at the end of TransactionUnitTests.cc
Related issue(s):
Fixes #1227
Notes for reviewer:
This is a refactor and formatting change only — no behavior or API changes.
Checklist