feat: bypass mech for users already contributed.#1231
feat: bypass mech for users already contributed.#1231rwalworth merged 2 commits intohiero-ledger:mainfrom
Conversation
Signed-off-by: Aditya Arya <arya050411@gmail.com>
|
Hey @Adityarya11 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1219 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
github-actions
bot
added
the
status: needs review
rwalworth
left a comment
rwalworth
left a comment
There was a problem hiding this comment.
LGTM, the bypass logic is clean and handles error cases well by falling through to the existing prerequisite check. Tests cover the key scenarios nicely, and the docs are updated. I left a couple of small non-blocking suggestions below.
Since this PR touches .github/ files, we'll need an approval from @hiero-ledger/github-maintainers before merging. Once that's in, this should be good to go!
rwalworth
removed
the
status: needs review
3 participants
Description:
Follows the instruction as per the issue. Added the Hierarchy array and the functionality to bypass the contributor.
Related issue(s):
Fixes #1219
Notes for reviewer:
Checklist