docs: Add missing documentation tags#1249
Conversation
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
|
Hey @freya-docs 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1236 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
|
Thank you for the PR, @freya-docs! However |
rwalworth
left a comment
There was a problem hiding this comment.
Thanks for the PR @freya-docs! The scope is correct - all 23 setter methods are covered and the @throws tags are in the right position (after @return, matching peer classes). Just one thing to fix that @Akshat8510 already pointed out below: the class name in every @throws tag says AccountUpdateTransaction instead of TokenCreateTransaction. Once you update all 23 occurrences, this will be good to go!
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
|
Hello, sorry, I've missed it. Please check if it is fine now. |
|
yeah it's fine now thanks for contributing :) |
This comment was marked as resolved.
This comment was marked as resolved.
rwalworth
left a comment
There was a problem hiding this comment.
The fix looks great, @freya-docs! I confirmed all 23 @throws tags now correctly read TokenCreateTransaction instead of AccountUpdateTransaction. Running the workflows and will merge when they pass.
Description:
This PR adds missing 'throws' documentation tags to setters methods in the TokenCreateTransaction.h file
Related issue(s):
Fixes #1236