Skip to content

docs: Add missing documentation tags#1249

Merged
rwalworth merged 7 commits intohiero-ledger:mainfrom
freya-docs:add-missing-documentation-tags
Mar 23, 2026
Merged

docs: Add missing documentation tags#1249
rwalworth merged 7 commits intohiero-ledger:mainfrom
freya-docs:add-missing-documentation-tags

Conversation

@freya-docs
Copy link
Copy Markdown
Contributor

Description:
This PR adds missing 'throws' documentation tags to setters methods in the TokenCreateTransaction.h file

Related issue(s):

Fixes #1236

@freya-docs freya-docs requested review from a team as code owners March 17, 2026 19:08
@freya-docs freya-docs requested a review from gsstoykov March 17, 2026 19:08
@github-actions
Copy link
Copy Markdown

Hey @freya-docs 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1236 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions bot added the status: needs review The pull request is ready for maintainer review label Mar 17, 2026
@Akshat8510
Copy link
Copy Markdown
Member

Thank you for the PR, @freya-docs! However

Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @freya-docs! The scope is correct - all 23 setter methods are covered and the @throws tags are in the right position (after @return, matching peer classes). Just one thing to fix that @Akshat8510 already pointed out below: the class name in every @throws tag says AccountUpdateTransaction instead of TokenCreateTransaction. Once you update all 23 occurrences, this will be good to go!

@rwalworth rwalworth added status: needs revision A pull request that requires changes before merge and removed status: needs review The pull request is ready for maintainer review labels Mar 17, 2026
@github-actions github-actions bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Mar 20, 2026
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
@freya-docs
Copy link
Copy Markdown
Contributor Author

Hello, sorry, I've missed it. Please check if it is fine now.

Copy link
Copy Markdown
Member

@Akshat8510 Akshat8510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Akshat8510
Copy link
Copy Markdown
Member

yeah it's fine now thanks for contributing :)

@Akshat8510

This comment was marked as resolved.

@freya-docs freya-docs changed the title Add missing documentation tags docs: Add missing documentation tags Mar 20, 2026
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks great, @freya-docs! I confirmed all 23 @throws tags now correctly read TokenCreateTransaction instead of AccountUpdateTransaction. Running the workflows and will merge when they pass.

@rwalworth rwalworth merged commit 53f6092 into hiero-ledger:main Mar 23, 2026
12 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Beginner]: Add missing @throws documentation tags to TokenCreateTransaction.h setters

3 participants