Skip to content

fix: Replace skill ordering in getIssueSkillLevel with SKILL_HIERARCHY#1251

Merged
rwalworth merged 1 commit intohiero-ledger:mainfrom
oGranny:fix/replace-inline-skill-1238
Mar 18, 2026
Merged

fix: Replace skill ordering in getIssueSkillLevel with SKILL_HIERARCHY#1251
rwalworth merged 1 commit intohiero-ledger:mainfrom
oGranny:fix/replace-inline-skill-1238

Conversation

@oGranny
Copy link
Copy Markdown
Contributor

@oGranny oGranny commented Mar 18, 2026

Description:
removes an inline, locally-defined skill-level ordering array in the GitHub automation script and replaces it with the shared SKILL_HIERARCHY constant.

Related issue(s):
Fixes #1238

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…SKILL_HIERARCHY constant

Signed-off-by: oGranny <ogranny.github.io@gmail.com>
@oGranny oGranny requested a review from a team as a code owner March 18, 2026 06:41
@oGranny oGranny requested a review from leninmehedy March 18, 2026 06:41
@github-actions
Copy link
Copy Markdown

Hey @oGranny 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1238 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions bot added the status: needs review The pull request is ready for maintainer review label Mar 18, 2026
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the change correctly replaces the inline skillLevels array with the shared SKILL_HIERARCHY constant, giving us a single source of truth for the skill ordering. I verified that SKILL_HIERARCHY contains the exact same values and is already imported. All 24 bot tests pass. Running the workflows now and will get this merged once they pass!

Congratulations on your first contribution to the Hiero C++ SDK @oGranny! 🎉 Thank you for taking the time to contribute!

@rwalworth rwalworth merged commit 31cdbbc into hiero-ledger:main Mar 18, 2026
12 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Replace inline skill ordering in getIssueSkillLevel with shared SKILL_HIERARCHY constant

3 participants