fix: Replace skill ordering in getIssueSkillLevel with SKILL_HIERARCHY#1251
Conversation
…SKILL_HIERARCHY constant Signed-off-by: oGranny <ogranny.github.io@gmail.com>
|
Hey @oGranny 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1238 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
rwalworth
left a comment
There was a problem hiding this comment.
LGTM - the change correctly replaces the inline skillLevels array with the shared SKILL_HIERARCHY constant, giving us a single source of truth for the skill ordering. I verified that SKILL_HIERARCHY contains the exact same values and is already imported. All 24 bot tests pass. Running the workflows now and will get this merged once they pass!
Congratulations on your first contribution to the Hiero C++ SDK @oGranny! 🎉 Thank you for taking the time to contribute!
Description:
removes an inline, locally-defined skill-level ordering array in the GitHub automation script and replaces it with the shared SKILL_HIERARCHY constant.
Related issue(s):
Fixes #1238
Checklist