Skip to content

remove unused hasLabel import in unassign command#1258

Merged
rwalworth merged 1 commit intohiero-ledger:mainfrom
davin-core:Remove-unused-hasLabel-import-in-unassign.js
Mar 23, 2026
Merged

remove unused hasLabel import in unassign command#1258
rwalworth merged 1 commit intohiero-ledger:mainfrom
davin-core:Remove-unused-hasLabel-import-in-unassign.js

Conversation

@davin-core
Copy link
Copy Markdown
Contributor

@davin-core davin-core commented Mar 19, 2026

Remove unused hasLabel import from .github/scripts/commands/unassign.js to clean up the code and reduce confusion for new contributors.

Remove hasLabel from the destructured import at line 13

Preserve all other imports and existing logic

Fixes #1255

@davin-core davin-core requested a review from a team as a code owner March 19, 2026 19:14
@davin-core davin-core requested a review from andrewb1269 March 19, 2026 19:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

Hey @davin-core 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1255 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions bot added the status: needs revision A pull request that requires changes before merge label Mar 19, 2026
@davin-core davin-core force-pushed the Remove-unused-hasLabel-import-in-unassign.js branch from 51a1b68 to 3eb632e Compare March 19, 2026 19:27
Signed-off-by: Davin <dev.davicheanin@gmail.com>
@davin-core davin-core force-pushed the Remove-unused-hasLabel-import-in-unassign.js branch from 3eb632e to 962ecc6 Compare March 19, 2026 19:32
@github-actions github-actions bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Mar 19, 2026
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the change is exactly right. Once we get an approval from @hiero-ledger/github-maintainers, we'll get this merged!

Congratulations on your first contribution to the Hiero C++ SDK, @davin-core! 🎉 Thank you for taking the time to contribute!

@rwalworth rwalworth merged commit 0c782a9 into hiero-ledger:main Mar 23, 2026
12 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Remove unused hasLabel import in unassign.js

3 participants