docs: fix typo in FileService.h doc comment#1259
Conversation
Signed-off-by: Davin <dev.davicheanin@gmail.com>
|
Hey @davin-core 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1257 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
94fcc4f to
fef0b73
Compare
Akshat8510
left a comment
There was a problem hiding this comment.
Hey @davin-core , thanks for the PR!
The PR Helper Bot is flagging your commit as unverified. Please sign your commit using a GPG/SSH key. You can fix this by running:
git commit --amend -S -s
This comment was marked as resolved.
This comment was marked as resolved.
fef0b73 to
a38fd61
Compare
Akshat8510
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing :)
rwalworth
left a comment
There was a problem hiding this comment.
LGTM, the fix is correct, minimal, and brings the appendFile doc comment into consistency with all the other functions in FileService.h. Running the workflows now and will merge!
Congratulations on your first contribution to the Hiero C++ SDK, @davin-core! 🎉 Thank you for taking the time to contribute!
This PR fixes a small typo in the documentation comment for the appendFile function in
src/tck/include/file/FileService.h.This has been corrected to:
@param params The parameters to use to append a file.Preserve all other imports and existing logic
Fixes #1257