Skip to content

docs: fix typo in FileService.h doc comment#1259

Merged
rwalworth merged 1 commit intohiero-ledger:mainfrom
davin-core:Fix-missing-word-to-in-FileService.h-appendFile-doc-comment
Mar 23, 2026
Merged

docs: fix typo in FileService.h doc comment#1259
rwalworth merged 1 commit intohiero-ledger:mainfrom
davin-core:Fix-missing-word-to-in-FileService.h-appendFile-doc-comment

Conversation

@davin-core
Copy link
Copy Markdown
Contributor

This PR fixes a small typo in the documentation comment for the appendFile function in
src/tck/include/file/FileService.h.
This has been corrected to:
@param params The parameters to use to append a file.

Preserve all other imports and existing logic

Fixes #1257

Signed-off-by: Davin <dev.davicheanin@gmail.com>
@davin-core davin-core requested review from a team as code owners March 20, 2026 03:08
@davin-core davin-core requested a review from gsstoykov March 20, 2026 03:08
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

Hey @davin-core 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1257 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions bot added the status: needs revision A pull request that requires changes before merge label Mar 20, 2026
@davin-core davin-core force-pushed the Fix-missing-word-to-in-FileService.h-appendFile-doc-comment branch from 94fcc4f to fef0b73 Compare March 20, 2026 03:13
Copy link
Copy Markdown
Member

@Akshat8510 Akshat8510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @davin-core , thanks for the PR!
The PR Helper Bot is flagging your commit as unverified. Please sign your commit using a GPG/SSH key. You can fix this by running:
git commit --amend -S -s

@Akshat8510

This comment was marked as resolved.

@davin-core davin-core changed the title Fix missing word "to" in FileService.h appendFile doc comment docs: fix typo in FileService.h doc comment Mar 20, 2026
@davin-core davin-core force-pushed the Fix-missing-word-to-in-FileService.h-appendFile-doc-comment branch from fef0b73 to a38fd61 Compare March 20, 2026 13:17
@github-actions github-actions bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Mar 20, 2026
Copy link
Copy Markdown
Member

@Akshat8510 Akshat8510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing :)

Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the fix is correct, minimal, and brings the appendFile doc comment into consistency with all the other functions in FileService.h. Running the workflows now and will merge!

Congratulations on your first contribution to the Hiero C++ SDK, @davin-core! 🎉 Thank you for taking the time to contribute!

@rwalworth rwalworth merged commit 304244e into hiero-ledger:main Mar 23, 2026
11 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Fix missing word "to" in FileService.h appendFile doc comment

3 participants