Skip to content

fix: Transaction list validation#1275

Merged
rwalworth merged 4 commits intomainfrom
01274-advanced-transaction-list-validation
Mar 31, 2026
Merged

fix: Transaction list validation#1275
rwalworth merged 4 commits intomainfrom
01274-advanced-transaction-list-validation

Conversation

@gsstoykov
Copy link
Copy Markdown
Contributor

Description:

Adds proper internal validation.

Related issue(s):

Fixes #1274

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov self-assigned this Mar 25, 2026
@gsstoykov gsstoykov requested review from a team as code owners March 25, 2026 11:41
@gsstoykov gsstoykov requested a review from SimiHunjan March 25, 2026 11:41
@gsstoykov gsstoykov linked an issue Mar 25, 2026 that may be closed by this pull request
6 tasks
@gsstoykov gsstoykov requested a review from agadzhalov March 25, 2026 11:41
@github-actions
Copy link
Copy Markdown

Hey @gsstoykov 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1274 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions bot added the status: needs review The pull request is ready for maintainer review label Mar 25, 2026
@rwalworth rwalworth added status: needs revision A pull request that requires changes before merge and removed status: needs review The pull request is ready for maintainer review labels Mar 25, 2026
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@github-actions github-actions bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Mar 26, 2026
rwalworth
rwalworth previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the feedback!

@rwalworth rwalworth added status: needs revision A pull request that requires changes before merge and removed status: needs review The pull request is ready for maintainer review labels Mar 27, 2026
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Mar 31, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 16 complexity . 32 duplication

Metric Results
Complexity 16
Duplication 32

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@github-actions github-actions bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Mar 31, 2026
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@rwalworth rwalworth merged commit 6e2943a into main Mar 31, 2026
13 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 31, 2026
@rwalworth rwalworth deleted the 01274-advanced-transaction-list-validation branch March 31, 2026 14:56
ParasSalonia pushed a commit to ParasSalonia/hiero-sdk-cpp that referenced this pull request Apr 3, 2026
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Advanced]: Transaction list validation

2 participants