fix: updated Fileservice.cc to handle mAdminKeys as value type

[ParasSalonia]

• Updated FileService.cc to correctly handle mAdminKeys as a value type instead of a pointer.

• Fixes [Beginner]: Build failure in TCK FileService.cc due to FileInfo mAdminKeys API change #1272

[github-actions]

Hey @ParasSalonia 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:

---

PR Checks

✅ DCO Sign-off -- All commits have valid sign-offs. Nice work!

---

✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded!

---

✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing!

---

✅ Issue Link -- Linked to #1272 (assigned to you).

---

🎉 All checks passed! Your PR is ready for review. Great job!

[rwalworth]

Thanks for the quick turnaround on this @ParasSalonia! The fix is correct - mAdminKeys is a KeyList value type in FileInfo, so the pointer/optional semantics needed to go, and toBytes() is the right call here.

One small thing: the clang-format lint check is failing because the replacement block isn't indented to match the surrounding code. Once that's fixed, we'll be good to merge!

[rwalworth]

Thanks for addressing the review feedback quickly, @ParasSalonia! The second commit fixes the brace positions, but the body of the if block still isn't indented to match the surrounding code. The clang-format check will continue to fail until this is resolved. Once the indentation is corrected the fix looks good and we can merge.

[ParasSalonia]

Hi @rwalworth,

I have made the requested changes. Could you please review them and let me know if any further improvements are needed?

[rwalworth]

The formatting is still incorrect. Please run clang-format-17 -i src/tck/src/file/FileService.cc to fix.

[codacy-production]

Not up to standards ⛔

🔴 Issues 1 medium

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category	Results
Complexity	1 medium

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

[ParasSalonia]

Thanks for the guidance! I rebased onto the latest main and re-ran clang-format from the repo root. I’ve pushed the updated changes — please let me know if everything looks correct now.

[rwalworth]

Hey @ParasSalonia, what version of clang-format are you running locally? It looks like you may be running a different version than what CI uses - the CI pins clang-format-17, and different versions produce different output for the same .clang-format config (the spaces-inside-braces behavior is one of those areas).

If you install and use clang-format-17 explicitly, it should match:

# Ubuntu/Debian
sudo apt install clang-format-17

# Then format and verify (from the repo root)
clang-format-17 -i src/tck/src/file/FileService.cc
clang-format-17 src/tck/src/file/FileService.cc | diff src/tck/src/file/FileService.cc -

No output from the diff means the file matches what CI expects. Once the lint check goes green, we can merge!

[ParasSalonia]

Hi @rwalworth,

• The latest changes include only the functional fix with correct formatting. The lint checks are now passing