Fixes #1301: Formatted src/sdk/tests with clang-format 17 and added the directory to the CI lint job matrix.#1312
Conversation
Fixes hiero-ledger#1301 Signed-off-by: landmark-achievement <3451978561@qq.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 1 medium |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
TIP This summary will be updated as you push new changes. Give us feedback
|
Hey @milestone-17 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ❌ GPG Signature -- Heads up! The following commits don't have a verified GPG signature:
You'll need to sign your commits with GPG (e.g. ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ❌ Issue Link -- Almost there! You are not assigned to the following linked issues: #1301. Please ensure you are assigned to all linked issues before opening a PR. You can comment ⏳ All checks must pass before this PR can be reviewed. You've got this! |
|
Thanks for working on this, @milestone-17! I can see you updated this PR from your previous attempt (#1311) to properly link the issue - nice job catching that. The code changes themselves look correct: the formatting is consistent with what clang-format 17 produces and the CI workflow addition follows the exact pattern we use for That said, I'm going to close this PR. Looking at your contribution history, you don't have any merged PRs in this repo yet, which means you haven't completed the two Good First Issues required before taking on a beginner issue like #1301. I know that's frustrating when the code itself is right, but the Good First Issues requirement isn't just a formality - it's specifically designed to get contributors comfortable with our workflow before moving on to larger contributions. The exact issues we've hit here (missing GPG signature, submitting without being assigned) are precisely what Good First Issues are meant to help you work through in a lower-stakes context. I also see you have PR #1313 open for issue #1299 in the same situation, so I'll be closing that one as well. Please start by picking up a couple of good-first-issues. Along the way you'll get practice requesting assignment, signing commits correctly with both The Signing Guide is a good reference for commit signing setup whenever you're ready. Feel free to ask questions - happy to help! |
Fixes #1301
Description:
clang-format the files
Add support for ...
-->
Related issue(s):
Fixes #1301
Notes for reviewer:
Checklist