Skip to content

Fixes #1301: Formatted src/sdk/tests with clang-format 17 and added the directory to the CI lint job matrix.#1312

Closed
milestone-17 wants to merge 1 commit intohiero-ledger:mainfrom
milestone-17:format-sdk-tests
Closed

Fixes #1301: Formatted src/sdk/tests with clang-format 17 and added the directory to the CI lint job matrix.#1312
milestone-17 wants to merge 1 commit intohiero-ledger:mainfrom
milestone-17:format-sdk-tests

Conversation

@milestone-17
Copy link
Copy Markdown

@milestone-17 milestone-17 commented Apr 4, 2026

Fixes #1301

Description:
clang-format the files

Add support for ...

  • Add config property
  • Change column name
  • Remove ...
    -->

Related issue(s):

Fixes #1301

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Fixes hiero-ledger#1301

Signed-off-by: landmark-achievement <3451978561@qq.com>
@codacy-production
Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 medium

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Complexity 1 medium

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Hey @milestone-17 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- Heads up! The following commits don't have a verified GPG signature:

  • 38cd49b style: format src/sdk/tests with clang-format 17

You'll need to sign your commits with GPG (e.g. git commit -S). See the Signing Guide for a step-by-step walkthrough.


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Almost there! You are not assigned to the following linked issues: #1301.

Please ensure you are assigned to all linked issues before opening a PR. You can comment /assign on the issue to grab it!


All checks must pass before this PR can be reviewed. You've got this!

@github-actions github-actions bot added the status: needs revision A pull request that requires changes before merge label Apr 4, 2026
@rwalworth
Copy link
Copy Markdown
Contributor

Thanks for working on this, @milestone-17! I can see you updated this PR from your previous attempt (#1311) to properly link the issue - nice job catching that. The code changes themselves look correct: the formatting is consistent with what clang-format 17 produces and the CI workflow addition follows the exact pattern we use for sdk and tck.

That said, I'm going to close this PR. Looking at your contribution history, you don't have any merged PRs in this repo yet, which means you haven't completed the two Good First Issues required before taking on a beginner issue like #1301. I know that's frustrating when the code itself is right, but the Good First Issues requirement isn't just a formality - it's specifically designed to get contributors comfortable with our workflow before moving on to larger contributions. The exact issues we've hit here (missing GPG signature, submitting without being assigned) are precisely what Good First Issues are meant to help you work through in a lower-stakes context. I also see you have PR #1313 open for issue #1299 in the same situation, so I'll be closing that one as well.

Please start by picking up a couple of good-first-issues. Along the way you'll get practice requesting assignment, signing commits correctly with both -s and -S, and linking your PRs to the right issue. The work on #1301 will still be here once you've got two of those merged - come back then and I'll get you assigned.

The Signing Guide is a good reference for commit signing setup whenever you're ready. Feel free to ask questions - happy to help!

@rwalworth rwalworth closed this Apr 4, 2026
@rwalworth rwalworth removed the status: needs revision A pull request that requires changes before merge label Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Beginner]: Add src/sdk/tests to the CI clang-format lint matrix

2 participants