Skip to content

Update documentation for isSafeSearchToken function fixes #1308#1314

Closed
JarvisX-Z wants to merge 2 commits intohiero-ledger:mainfrom
JarvisX-Z:patch-6
Closed

Update documentation for isSafeSearchToken function fixes #1308#1314
JarvisX-Z wants to merge 2 commits intohiero-ledger:mainfrom
JarvisX-Z:patch-6

Conversation

@JarvisX-Z
Copy link
Copy Markdown
Contributor

Clarify allowed characters and bot suffix in documentation.

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Clarify allowed characters and bot suffix in documentation.

Signed-off-by: Jyotish <jyotishdeka091@gmail.com>
@JarvisX-Z JarvisX-Z requested a review from a team as a code owner April 4, 2026 04:18
@JarvisX-Z JarvisX-Z requested a review from leninmehedy April 4, 2026 04:18
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Hey @JarvisX-Z 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- This PR is not linked to any issue.

Please reference an issue using a closing keyword (e.g. Fixes #123) and ensure the issue is assigned to you. Every PR needs a home!


All checks must pass before this PR can be reviewed. You've got this!

@github-actions github-actions bot added the status: needs revision A pull request that requires changes before merge label Apr 4, 2026
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 4, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@JarvisX-Z JarvisX-Z changed the title Update documentation for isSafeSearchToken function #1308 Update documentation for isSafeSearchToken function fixes #1308 Apr 4, 2026
@rwalworth
Copy link
Copy Markdown
Contributor

Thanks for contributing, @JarvisX-Z. I need to close this PR as issue #1308 is not assigned to you, and @Ridhi-03Kumari has already expressed interest in working on it on the issue itself. I've directed them to claim it, so it will be taken shortly.

The documentation change itself is accurate - the regex does support [bot] suffixes and your JSDoc correctly reflects that. The issue here is purely process.

A note on workflow:
I've raised the "please wait for assignment before opening a PR" concern on your previous PRs - I closed #1114 for it and left an explicit warning on #1156. I understand you're eager to contribute, and that's great! But the assignment step protects everyone: it ensures you won't put in work on something that's already being done by someone else - exactly what's happened here.

If you're looking for something to work on, check out the open unassigned issues and comment /assign on one before starting. And please feel free to reach out if you have any questions or concerns about the process - happy to help clarify so we can avoid this happening again!

@rwalworth rwalworth closed this Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs revision A pull request that requires changes before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants