-
Notifications
You must be signed in to change notification settings - Fork 144
feat: add issue reminder bot #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: prajeeta pal <[email protected]>
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! From the Hiero Python SDK Team |
Signed-off-by: prajeeta <[email protected]>
Signed-off-by: prajeeta pal <[email protected]>
Signed-off-by: prajeeta <[email protected]>
|
Request review if available @hiero-ledger/hiero-sdk-python-triage |
|
Hi @prajeeta15 |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prajeeta15
Have you tested this on a fork?
Please follow https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/testing_forks.md
Please ensure it posts on your fork issues for the test, then send a link of the bot working correctly
you'll need to enable issues on your fork by clicking inside settings
Signed-off-by: prajeeta pal <[email protected]>
I tested on my fork by following https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/testing_forks.md |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prajeeta15
Would you mind adding some more explicit safety nets?
Otherwise happy to approve this
|
Hi @prajeeta15 what do you think? Should we ensure the DRY run variable works as intended? |
|
@prajeeta15 This is great work! I agree with the point about the DRY_RUN variable. The current behavior is technically correct, but making it explicit would improve clarity for future maintainers. I don’t see this as blocking, but explicitly passing DRY_RUN=false on scheduled runs or clearly documenting the accepted values would make the intent easier to understand. Otherwise, the script and workflow look solid to me. |
Signed-off-by: prajeeta pal <[email protected]>
Signed-off-by: prajeeta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prajeeta15
I am unable to merge this - you have removed other people's changelog entries
https://github.com/hiero-ledger/hiero-sdk-python/pull/1027/changes#diff-9e7a22da35715c25129d7199f2530a872c4ad3d119722caea17a5ff57e570aec
I would recommend to copy in the code of the current main changelog to your branch, then add in just your change :)
While you do that, could you change the trigger time to 1pm
You use quite a few API calls, and since we have other bots, this may cause problems
Please first make sure to fetch from upstream and push to your origin main as described in rebasing.md
Thanks
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue is outstanding, please look at your changelog submission here
https://github.com/hiero-ledger/hiero-sdk-python/pull/1027/changes#diff-9e7a22da35715c25129d7199f2530a872c4ad3d119722caea17a5ff57e570aec
merging will not resolve this using the editor, you must copy in the changelog i think
Signed-off-by: prajeeta pal <[email protected]>
|
@exploreriii fixed the changelog.md issue. I might have missed them during "resolve conflicts" |
|
Hello, this is the Office Hour Bot. This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request or receive assistance from a maintainer. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here to be notified of any changes. |
|
Excellent work @prajeeta15 !!!!! and thank you!!! |


Description:
Add automated reminder for assigned issues with no linked pull requests
This PR introduces a new ReminderBot workflow that automatically notifies contributors when an issue has been assigned for 7+ days but no pull request has been created. This helps ensure that issues do not remain assigned indefinitely without progress.
What’s included:
.github/scripts/issue_reminder_no_pr.sh.github/workflows/bot-issue-reminder-no-pr.yml- Runs daily at 10:00 UTC
- Supports manual triggering via workflow_dispatch
- Uses GITHUB_TOKEN with appropriate permissions
The reminder message posted is:
"Hi, this is ReminderBot. This issue has been assigned but has had no pull request created. Are you still planning on working on the issue?
From the Python SDK Team"
Fixes #951
Notes for reviewer: