-
Notifications
You must be signed in to change notification settings - Fork 147
feat: add tests for key format #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tests for key format #1092
Conversation
|
[commit-verification-bot] To achieve verified status, please read: Remember, you require a GPG key and each commit must be signed with: Thank you for contributing! From the Hiero Python SDK Team |
4bd0e88 to
272ad31
Compare
|
Hi, this is WorkflowBot.
|
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aceppaluni please fix your signing 👍
ea27572 to
b34761a
Compare
|
Hello, this is the Office Hour Bot. This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request or receive assistance from a maintainer. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here to be notified of any changes. |
|
Request review if available @hiero-ledger/hiero-sdk-python-triage |
nadineloepfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great PR! we could also raise a follow up issue to uplift format_key in key_format.py.
First, it would be good to rename the method to format_key.. then it would also be good to check not just for ed25519 but also ECDSA. Currently, when a ECDSA key is passed to format_key, it falls through to the generic fallback.
Would be nice to have a check for ECDSA_secp256k1(hex-encoded).. but that's out of scope for this PR
Signed-off-by: aceppaluni <[email protected]> Signed-off-by: aceppaluni <[email protected]>
Signed-off-by: aceppaluni <[email protected]>
Signed-off-by: aceppaluni <[email protected]>
b34761a to
ce30e0a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1092 +/- ##
==========================================
+ Coverage 90.91% 91.04% +0.13%
==========================================
Files 139 139
Lines 8409 8409
==========================================
+ Hits 7645 7656 +11
+ Misses 764 753 -11 🚀 New features to boost your workflow:
|
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aceppaluni !
Signed-off-by: aceppaluni <[email protected]> Signed-off-by: aceppaluni <[email protected]> Signed-off-by: prajeeta pal <[email protected]>
Description:
Added unit tests for:
key_format.py.
The goal of this PR is to increase test coverage of key_format.py to be <= 85%
Related issue(s):
Fixes #990
Notes for reviewer:
Checklist