Skip to content

Conversation

@aceppaluni
Copy link
Contributor

Description:

Added unit tests for:

key_format.py.
The goal of this PR is to increase test coverage of key_format.py to be <= 85%

Related issue(s):

Fixes #990

Notes for reviewer:

  • Ensured coverage percentage is <= 85%
  • Used command pytest --cov=. --cov-report=term-missing tests/unit
  • Provided coverage photo
2025-12-10

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions
Copy link

[commit-verification-bot]
Hi, this is VerificationBot.
Your pull request cannot be merged as it has unverified commits.
View your commit verification status: Commits Tab.

To achieve verified status, please read:

Remember, you require a GPG key and each commit must be signed with:
git commit -S -s -m "Your message here"

Thank you for contributing!

From the Hiero Python SDK Team

@aceppaluni aceppaluni marked this pull request as ready for review December 14, 2025 19:59
@github-actions
Copy link

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

@exploreriii exploreriii marked this pull request as draft December 14, 2025 20:49
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aceppaluni please fix your signing 👍

@aceppaluni aceppaluni force-pushed the AddTestsForKeyFormat branch 2 times, most recently from ea27572 to b34761a Compare December 16, 2025 19:12
@aceppaluni aceppaluni marked this pull request as ready for review December 16, 2025 19:28
@github-actions
Copy link

Hello, this is the Office Hour Bot.

This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request or receive assistance from a maintainer.

Details:

Disclaimer: This is an automated reminder. Please verify the schedule here to be notified of any changes.

@exploreriii
Copy link
Contributor

Request review if available @hiero-ledger/hiero-sdk-python-triage

nadineloepfe
nadineloepfe previously approved these changes Dec 17, 2025
Copy link
Contributor

@nadineloepfe nadineloepfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great PR! we could also raise a follow up issue to uplift format_key in key_format.py.
First, it would be good to rename the method to format_key.. then it would also be good to check not just for ed25519 but also ECDSA. Currently, when a ECDSA key is passed to format_key, it falls through to the generic fallback.
Would be nice to have a check for ECDSA_secp256k1(hex-encoded).. but that's out of scope for this PR

aceppaluni and others added 3 commits December 17, 2025 11:41
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   90.91%   91.04%   +0.13%     
==========================================
  Files         139      139              
  Lines        8409     8409              
==========================================
+ Hits         7645     7656      +11     
+ Misses        764      753      -11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aceppaluni !

@exploreriii exploreriii merged commit 7d1aa58 into hiero-ledger:main Dec 17, 2025
18 checks passed
prajeeta15 pushed a commit to prajeeta15/hiero-sdk-python that referenced this pull request Dec 23, 2025
Signed-off-by: aceppaluni <[email protected]>
Signed-off-by: aceppaluni <[email protected]>
Signed-off-by: prajeeta pal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create tests/unit for src/hiero_sdk_python/utils/key_format.py

3 participants