-
Notifications
You must be signed in to change notification settings - Fork 147
docs: add GFI-Guidelines Doc File #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: aceppaluni <[email protected]>
WalkthroughA new comprehensive Good First Issue (GFI) guidelines document has been added to the SDK repository, accompanied by a changelog entry. The guidelines define GFI criteria, provide concrete examples across code changes, refactoring, documentation, and testing, and include SDK-specific customization notes and maintainer responsibilities. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🪛 LanguageTooldocs/GFI/GFI-Guidelines.md[uncategorized] ~20-~20: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL) [style] ~22-~22: Consider a different adjective to strengthen your wording. (DEEP_PROFOUND) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi, this is WorkflowBot.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1128 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 139 139
Lines 8409 8409
=======================================
Hits 7656 7656
Misses 753 753 🚀 New features to boost your workflow:
|
Signed-off-by: aceppaluni <[email protected]>
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - works well
We need these docs urgently, we can improve them over time
Signed-off-by: aceppaluni <[email protected]> Signed-off-by: prajeeta pal <[email protected]>
Description:
This PR aims to add in the Good-First-Issue documentation for the scope of what good-first-issues should contain.
Related issue(s): N/A
Fixes #
No issue number, one can be created and applied.
Notes for reviewer:
Explains what the purpose and scope should be when creating good-first-issues.
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.