Skip to content

Conversation

@suyash1567
Copy link
Contributor

@suyash1567 suyash1567 commented Dec 23, 2025

Description: Added method chaining example at the end of Section 3 in docs/sdk_developers/training/coding_token_transactions.md

Related issue(s):

Fixes #1194

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions
Copy link

[commit-verification-bot]
Hi, this is VerificationBot.
Your pull request cannot be merged as it has unverified commits.
View your commit verification status: Commits Tab.

To achieve verified status, please read:

Remember, you require a GPG key and each commit must be signed with:
git commit -S -s -m "Your message here"

Thank you for contributing!

From the Hiero Python SDK Team

@exploreriii
Copy link
Contributor

Hi this is looking good please, is it ready to review?

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         139      139           
  Lines        8447     8447           
=======================================
  Hits         7711     7711           
  Misses        736      736           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suyash1567
Copy link
Contributor Author

@exploreriii Yes please go ahead and review

@exploreriii exploreriii marked this pull request as ready for review December 23, 2025 12:46
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

📝 Walkthrough

Walkthrough

Adds documentation demonstrating method chaining for TokenAssociateTransaction in the developer training guide and inserts a corresponding changelog entry; includes comparative code examples (standard vs. chained usage).

Changes

Cohort / File(s) Summary
Documentation Updates
CHANGELOG.md, docs/sdk_developers/training/coding_token_transactions.md
Added a changelog entry and a new subsection (Setters and Method Chaining) showing method chaining for TokenAssociateTransaction, with example code comparing line-by-line setters vs. chained calls.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs: add method chaining examples' clearly and concisely summarizes the primary change: adding documentation examples for method chaining.
Description check ✅ Passed The description is related to the changeset, mentioning the addition of method chaining examples to the coding_token_transactions.md file and referencing issue #1194.
Linked Issues check ✅ Passed The PR successfully implements the requirements from issue #1194: adds method chaining code examples to Section 3 of coding_token_transactions.md, updates CHANGELOG.md per guidelines, and uses proper commit messaging.
Out of Scope Changes check ✅ Passed All changes are directly aligned with issue #1194 objectives: only documentation updates and changelog entries were added with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea91f78 and a42c2b1.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • docs/sdk_developers/training/coding_token_transactions.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/sdk_developers/training/coding_token_transactions.md

72-72: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


80-80: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: build-and-test (3.12)
  • GitHub Check: build-and-test (3.10)
  • GitHub Check: build-and-test (3.13)
  • GitHub Check: build-and-test (3.11)
  • GitHub Check: run-examples
  • GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
CHANGELOG.md (1)

12-12: Verify issue reference in changelog entry.

The changelog entry references issue #1194, but this PR is #1200. Confirm whether #1194 is the related issue this documentation change addresses, or if the reference should be updated to #1200.

docs/sdk_developers/training/coding_token_transactions.md (1)

50-81: Documentation content is clear and well-structured.

The method chaining explanation at line 68 with concrete examples effectively demonstrates the benefit of the setter pattern. The side-by-side comparison clearly shows both the standard and chained approaches, which will help developers understand the flexibility of the API design.

@exploreriii exploreriii marked this pull request as draft December 23, 2025 12:49
@Adityarya11
Copy link
Contributor

@exploreriii Yes please go ahead and review

@suyash1567 first of all in the PR you should write the stuff the description
At least mention the issue no. In the Fixes...

Copy link
Contributor

@Adityarya11 Adityarya11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the correct formatting for the markdown @suyash1567 and you are good to go👍

Signed-off-by: Your Name <[email protected]>
@suyash1567
Copy link
Contributor Author

Hi, @exploreriii you can review the code now

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!
Thanks for taking the time to get this just right

@exploreriii exploreriii marked this pull request as ready for review December 23, 2025 16:13
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a42c2b1 and 7ae7f9c.

📒 Files selected for processing (1)
  • docs/sdk_developers/training/coding_token_transactions.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/sdk_developers/training/coding_token_transactions.md

79-79: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


81-81: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above

(MD022, blanks-around-headings)


81-81: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


82-82: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: run-examples
  • GitHub Check: build-and-test (3.11)
  • GitHub Check: build-and-test (3.10)
  • GitHub Check: build-and-test (3.12)
  • GitHub Check: build-and-test (3.13)
  • GitHub Check: Codacy Static Code Analysis

@exploreriii exploreriii merged commit 855f399 into hiero-ledger:main Dec 23, 2025
18 checks passed
@exploreriii
Copy link
Contributor

Great work @suyash1567 thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Add code examples for Method Chaining in coding_token_transactions.md

3 participants