-
Notifications
You must be signed in to change notification settings - Fork 144
docs: add method chaining examples #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[commit-verification-bot] To achieve verified status, please read: Remember, you require a GPG key and each commit must be signed with: Thank you for contributing! From the Hiero Python SDK Team |
Signed-off-by: Your Name <[email protected]>
Signed-off-by: Your Name <[email protected]>
|
Hi this is looking good please, is it ready to review? |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 139 139
Lines 8447 8447
=======================================
Hits 7711 7711
Misses 736 736 🚀 New features to boost your workflow:
|
|
@exploreriii Yes please go ahead and review |
📝 WalkthroughWalkthroughAdds documentation demonstrating method chaining for TokenAssociateTransaction in the developer training guide and inserts a corresponding changelog entry; includes comparative code examples (standard vs. chained usage). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.mddocs/sdk_developers/training/coding_token_transactions.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/sdk_developers/training/coding_token_transactions.md
72-72: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
80-80: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: build-and-test (3.12)
- GitHub Check: build-and-test (3.10)
- GitHub Check: build-and-test (3.13)
- GitHub Check: build-and-test (3.11)
- GitHub Check: run-examples
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
CHANGELOG.md (1)
12-12: Verify issue reference in changelog entry.The changelog entry references issue #1194, but this PR is #1200. Confirm whether #1194 is the related issue this documentation change addresses, or if the reference should be updated to #1200.
docs/sdk_developers/training/coding_token_transactions.md (1)
50-81: Documentation content is clear and well-structured.The method chaining explanation at line 68 with concrete examples effectively demonstrates the benefit of the setter pattern. The side-by-side comparison clearly shows both the standard and chained approaches, which will help developers understand the flexibility of the API design.
@suyash1567 first of all in the PR you should write the stuff the description |
Adityarya11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the correct formatting for the markdown @suyash1567 and you are good to go👍
Signed-off-by: Your Name <[email protected]>
|
Hi, @exploreriii you can review the code now |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super!
Thanks for taking the time to get this just right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
docs/sdk_developers/training/coding_token_transactions.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/sdk_developers/training/coding_token_transactions.md
79-79: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
81-81: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above
(MD022, blanks-around-headings)
81-81: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
82-82: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: run-examples
- GitHub Check: build-and-test (3.11)
- GitHub Check: build-and-test (3.10)
- GitHub Check: build-and-test (3.12)
- GitHub Check: build-and-test (3.13)
- GitHub Check: Codacy Static Code Analysis
|
Great work @suyash1567 thank you very much |
Description: Added method chaining example at the end of Section 3 in docs/sdk_developers/training/coding_token_transactions.md
Related issue(s):
Fixes #1194
Notes for reviewer:
Checklist