-
Notifications
You must be signed in to change notification settings - Fork 146
fix: correct step-security/harden-runner SHA in merge conflict bot workflow #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rkflow Replace incorrect SHA with correct one for v2.14.0 release (#1278) Signed-off-by: cheese-cakee <[email protected]>
📝 WalkthroughWalkthroughTwo files were updated to correct an incorrect commit hash reference for the step-security/harden-runner action in a GitHub Actions workflow and to document this correction in the changelog. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/bot-merge-conflict.ymlCHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/**/*
⚙️ CodeRabbit configuration file
.github/workflows/**/*: Review workflows as security-sensitive infrastructure.A good workflow is small, focused, and boring.
If a workflow is clever, generic, or overly flexible, it is a risk.
PRIORITY 0 — ABSOLUTE REQUIREMENTS
- All third-party actions MUST be pinned to full commit SHAs, similar to other workflows.
permissions:MUST be explicitly declared and minimally scoped.- Workflows MUST behave safely when executed from forks.
- YAML MUST orchestrate steps, not implement business logic.
- Any workflow that mutates GitHub state MUST support dry-run mode.
- Dry-run behavior must be explicit and visible in logs.
- Workflows MUST NOT modify repository source code outside
.github/.
PRIORITY 1 — SCOPE, FOCUS & RESTRAINT
- The title of each workflow must be relevant, match similar naming schemes, and match its script filename.
- Each workflow MUST have a single, clearly defined objective and SHOULD document this in a top-level comment.
- Flag workflows that:
- Attempt to be generic “frameworks”
- Include speculative or future-facing logic
- Perform actions unrelated to the stated goal
- Over-abstraction and excess flexibility are maintenance risks.
PRIORITY 2 — INPUT HARDENING
- Treat ALL GitHub event data as potentially hostile input, including:
- issue titles, bodies, and comments
- labels, usernames, branch names
- Free-form user input MUST NOT be passed directly into:
- shell commands
- gh CLI arguments
- Node.js exec / spawn calls
- Require strict allowlists or exact string matches.
- Flag any use of:
- eval or bash -c
- backticks or $(...) with user-controlled input
------------------...
Files:
.github/workflows/bot-merge-conflict.yml
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md
76-76: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
.github/workflows/bot-merge-conflict.yml (1)
36-36: SHA update is correct and follows security best practices.The change to pin
step-security/harden-runnerto the full commit SHA20cf305ff2072d973412fa9b1e3a4f227bda3c76(v2.14.0) aligns with PRIORITY 0 requirements. This SHA is consistently used across all updated workflows in the repository, and no instances of the old SHA remain. All other third-party actions in this workflow are also properly pinned.
| ### Fixed | ||
| - Fixed step-security/harden-runner action SHA in merge conflict bot workflow (#1278) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Duplicate "Fixed" section — merge with existing section at line 122.
This PR introduces a duplicate "Fixed" section under "Unreleased". The changelog format requires only one section per category per release. A "Fixed" section already exists at line 122.
Additionally, there's a missing blank line before the new heading (line 76), as flagged by static analysis.
🔎 Proposed fix
Move the entry to the existing "Fixed" section. Remove lines 76-78 and add the entry after line 122:
- Added merge conflict bot workflow (`.github/workflows/bot-merge-conflict.yml`) and helper script (`.github/scripts/bot-merge-conflict.js`) to detect and notify about PR merge conflicts, with retry logic for unknown mergeable states, idempotent commenting, and push-to-main recheck logic (#1247)
-### Fixed
-- Fixed step-security/harden-runner action SHA in merge conflict bot workflow (#1278)
-
### Changed
- Bumped requests from 2.32.3 to 2.32.4 to 2.32.5Then, at line 122, add the entry to the existing "Fixed" section:
### Fixed
+- Fixed step-security/harden-runner action SHA in merge conflict bot workflow (#1278)
- Fixed the README account balance example to use correct SDK APIs and provide a runnable testnet setup. (#1250)Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
76-76: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check yourlatest commit is not signed correclty
https://github.com/hiero-ledger/hiero-sdk-python/pull/1279/checks?check_run_id=59234481489
| - Added merge conflict bot workflow (`.github/workflows/bot-merge-conflict.yml`) and helper script (`.github/scripts/bot-merge-conflict.js`) to detect and notify about PR merge conflicts, with retry logic for unknown mergeable states, idempotent commenting, and push-to-main recheck logic (#1247) | ||
|
|
||
| ### Fixed | ||
| - Fixed step-security/harden-runner action SHA in merge conflict bot workflow (#1278) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be line 123
|
Closing this PR due to GitHub Actions caching issues. Created new PR #1280 with the same fix. |
|
Hi, this is WorkflowBot.
|
Fixes #1278
Corrected the SHA for step-security/harden-runner action in merge conflict bot workflow.