Skip to content

Conversation

@exploreriii
Copy link
Contributor

Description:
Fixes incorrect casing used in GFI bot

Related issue(s):

Fixes #1292

Tested on fork
exploreriii#67

Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         139      139           
  Lines        8466     8466           
=======================================
  Hits         7771     7771           
  Misses        695      695           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@exploreriii exploreriii requested a review from manishdait January 1, 2026 17:46
@exploreriii exploreriii marked this pull request as ready for review January 1, 2026 17:46
@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

📝 Walkthrough

Walkthrough

This pull request corrects a label casing mismatch in the GFI notification workflow. The script previously checked for "good first issue" (lowercase) but the actual label is "Good First Issue" (title case). The fix updates the label check and adds a corresponding changelog entry.

Changes

Cohort / File(s) Summary
Script Fix
\.github/scripts/gfi_notify_team.js
Updated GFI label check from lowercase "good first issue" to title case "Good First Issue" to match actual label casing
Documentation
CHANGELOG.md
Added changelog entry "GFI workflow casing" to the Unreleased/Added section

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: fixing the casing of the GFI label check from lowercase to 'Good First Issue'.
Description check ✅ Passed The description is directly related to the changeset, explaining that it fixes incorrect casing in the GFI bot and references the related issue #1292.
Linked Issues check ✅ Passed The PR successfully addresses all coding requirements from issue #1292: updating the label casing from 'good first issue' to 'Good First Issue' and adding a changelog entry.
Out of Scope Changes check ✅ Passed All changes are directly within scope: the label casing fix in .github/scripts/gfi_notify_team.js and the changelog entry are exactly what was requested in issue #1292.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd9ca69 and bc643f2.

📒 Files selected for processing (2)
  • .github/scripts/gfi_notify_team.js
  • CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
.github/scripts/**/*.js

⚙️ CodeRabbit configuration file

.github/scripts/**/*.js: Review JavaScript scripts as long-lived automation code.

Scripts must remain:

  • Focused

  • Readable

  • Purpose-built

  • All context.payload fields MUST be validated

  • Free-form text MUST NOT be trusted

  • Dynamic code execution is prohibited

  • Avoid child_process.exec; prefer execFile if needed

  • All async operations MUST be wrapped in try/catch

  • Errors MUST include contextual metadata

  • Duplicate API calls MUST be avoided

  • Marker-based deduplication is required

  • Scripts MUST NOT assume write access

  • Permission failures MUST be handled gracefully

Files:

  • .github/scripts/gfi_notify_team.js
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md

125-125: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-and-test (3.10)
  • GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
.github/scripts/gfi_notify_team.js (1)

54-55: LGTM! Label casing corrected.

The fix correctly updates the label check to use "Good First Issue" (title case) instead of "good first issue" (lowercase), which resolves the issue where the bot was failing to recognize properly labeled issues.

The script already follows all required guidelines for GitHub Actions scripts including:

  • Proper payload validation
  • Try/catch error handling
  • Marker-based deduplication
  • Graceful permission failure handling

@manishdait manishdait merged commit e53acb1 into hiero-ledger:main Jan 1, 2026
24 of 25 checks passed
@exploreriii exploreriii deleted the fix-casing-2 branch January 3, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Fix casing in .github/scripts/gfi_notify_team.js

2 participants