-
Notifications
You must be signed in to change notification settings - Fork 147
fix: casing for good first issue bot #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1295 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 139 139
Lines 8466 8466
=======================================
Hits 7771 7771
Misses 695 695 🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthroughThis pull request corrects a label casing mismatch in the GFI notification workflow. The script previously checked for "good first issue" (lowercase) but the actual label is "Good First Issue" (title case). The fix updates the label check and adds a corresponding changelog entry. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/scripts/gfi_notify_team.jsCHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
.github/scripts/**/*.js
⚙️ CodeRabbit configuration file
.github/scripts/**/*.js: Review JavaScript scripts as long-lived automation code.Scripts must remain:
Focused
Readable
Purpose-built
All
context.payloadfields MUST be validatedFree-form text MUST NOT be trusted
Dynamic code execution is prohibited
Avoid
child_process.exec; preferexecFileif neededAll async operations MUST be wrapped in try/catch
Errors MUST include contextual metadata
Duplicate API calls MUST be avoided
Marker-based deduplication is required
Scripts MUST NOT assume write access
Permission failures MUST be handled gracefully
Files:
.github/scripts/gfi_notify_team.js
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md
125-125: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-and-test (3.10)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
.github/scripts/gfi_notify_team.js (1)
54-55: LGTM! Label casing corrected.The fix correctly updates the label check to use "Good First Issue" (title case) instead of "good first issue" (lowercase), which resolves the issue where the bot was failing to recognize properly labeled issues.
The script already follows all required guidelines for GitHub Actions scripts including:
- Proper payload validation
- Try/catch error handling
- Marker-based deduplication
- Graceful permission failure handling
Description:
Fixes incorrect casing used in GFI bot
Related issue(s):
Fixes #1292
Tested on fork
exploreriii#67