-
Notifications
You must be signed in to change notification settings - Fork 144
docs: advanced issue guidelines #1331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: advanced issue guidelines #1331
Conversation
Signed-off-by: exploreriii <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1331 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 139 139
Lines 8515 8515
=======================================
Hits 7859 7859
Misses 656 656 🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthroughThe PR adds advanced issue guidelines documentation and updates the changelog. A new file defines criteria, examples, and maintainer guidance for Advanced Issues across multiple categories including source changes, architecture, typing, documentation, examples, and testing. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.mddocs/maintainers/advanced-issue-guidelines.md
🧰 Additional context used
📓 Path-based instructions (1)
docs/**
⚙️ CodeRabbit configuration file
docs/**: You are reviewing documentation for the Hiero Python SDK. These pages serve both SDK users and SDK developers.Priority 1 - Correctness (code, commands, links)
- Verify code snippets conceptually run and match the current SDK API.
- Check shell commands and workflow steps against actual project tooling.
- Validate URLs and cross-references; flag broken or misleading links.
Priority 2 - Clarity and completeness
- Ensure each page states its purpose and expected outcome early.
- Prefer concrete, step-wise explanations over vague descriptions.
- Highlight missing prerequisites that would block a reader.
- For larger gaps, suggest filing a follow-up issue instead of blocking.
Priority 3 - Consistency and navigation
- Encourage consistent terminology with the SDK and examples.
- Check headings form a logical reading path.
- Confirm each page makes clear which audience it serves.
PHILOSOPHY
- Treat docs as work-in-progress: optimize for correctness and clarity over perfection.
- Keep feedback concise, action-oriented, and focused on reader success.
- Do not request large-scale restructures unless current structure blocks understanding.
AVOID
- Avoid lint-style feedback on Markdown formatting or minor wording.
- Avoid proposing new conventions without clear benefit.
- Avoid turning every high-level gap into a blocker.
Files:
docs/maintainers/advanced-issue-guidelines.md
🪛 LanguageTool
docs/maintainers/advanced-issue-guidelines.md
[style] ~78-~78: Consider a different adjective to strengthen your wording.
Context: ...r abstractions - Bug fixes that require deep investigation across layers - Improveme...
(DEEP_PROFOUND)
🪛 markdownlint-cli2 (0.18.1)
docs/maintainers/advanced-issue-guidelines.md
174-174: Blank line inside blockquote
(MD028, no-blanks-blockquote)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
docs/maintainers/advanced-issue-guidelines.md (2)
27-49: Well-structured purpose statement with clear audience expectations.The Purpose section (lines 27–49) clearly articulates the intent of Advanced Issues, explicitly names expected contributor skills, and sets realistic expectations. This aligns well with the PR objective to create guidelines analogous to the Good First Issues guidelines while targeting experienced contributors.
52-178: Comprehensive categorization and clear rule-of-thumb guidance.The six categories (Source Changes, Architecture, Typing, Documentation, Examples, Testing) provide concrete decision boundaries with specific "Allowed" and "Not Allowed" patterns. The rule-of-thumb at line 169–177 gives maintainers a practical heuristic to distinguish Advanced Issues from Intermediate ones. This structure supports the goals stated in issue #1327.
Description:
Adds a guideline for advanced issues
Related issue(s):
Fixes #1327