-
Notifications
You must be signed in to change notification settings - Fork 144
refactor(github): rename bot-inactivity workflow files #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(github): rename bot-inactivity workflow files #1356
Conversation
Remove "-phase" suffix from bot-inactivity workflow files since the process no longer uses phased execution. Changes: - .github/scripts/bot-inactivity-unassign-phase.sh -> bot-inactivity-unassign.sh - .github/workflows/bot-inactivity-unassign-phase.yml -> bot-inactivity-unassign.yml - Updated workflow step name to remove phase reference - Added CHANGELOG.md entry Signed-off-by: cxhello <[email protected]>
|
@exploreriii Thank you for your patience in directing this, I have resolved the problems I encountered submitting it. |
📝 WalkthroughWalkthroughTwo files were renamed to remove the "-phase" suffix from the bot inactivity workflow and script, reflecting that the process no longer uses phased execution. The workflow file reference to the script was updated accordingly, and a changelog entry was added documenting the change. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/bot-inactivity-unassign.yml (1)
32-41: LGTM! Rename successfully aligns workflow and script names.The changes correctly update the step name and script reference to remove the "-phase" suffix. The workflow name (
bot-inactivity-unassign) now matches the script filename (bot-inactivity-unassign.sh), satisfying PRIORITY 1 coding guidelines for.github/workflowsfiles.All security requirements are met:
- Actions pinned to full commit SHAs ✓
- Permissions explicitly scoped ✓
- Dry-run support with safe defaults ✓
Optional improvement for future consideration:
Consider adding a
concurrencygroup to prevent overlapping executions:concurrency: group: inactivity-unassign cancel-in-progress: falseThis would ensure that scheduled runs or manual dispatches don't process the same issues/PRs simultaneously. (This is a pre-existing gap, not introduced by this PR.)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
.github/scripts/bot-inactivity-unassign.sh.github/workflows/bot-inactivity-unassign.ymlCHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/**/*
⚙️ CodeRabbit configuration file
.github/workflows/**/*: Review workflows as security-sensitive infrastructure.A good workflow is small, focused, and boring.
If a workflow is clever, generic, or overly flexible, it is a risk.
PRIORITY 0 — ABSOLUTE REQUIREMENTS
- All third-party actions MUST be pinned to full commit SHAs, similar to other workflows.
permissions:MUST be explicitly declared and minimally scoped.- Workflows MUST behave safely when executed from forks.
- YAML MUST orchestrate steps, not implement business logic.
- Any workflow that mutates GitHub state MUST support dry-run mode.
- Dry-run behavior must be explicit and visible in logs.
- Workflows MUST NOT modify repository source code outside
.github/.
PRIORITY 1 — SCOPE, FOCUS & RESTRAINT
- The title of each workflow must be relevant, match similar naming schemes, and match its script filename.
- Each workflow MUST have a single, clearly defined objective and SHOULD document this in a top-level comment.
- Flag workflows that:
- Attempt to be generic “frameworks”
- Include speculative or future-facing logic
- Perform actions unrelated to the stated goal
- Over-abstraction and excess flexibility are maintenance risks.
PRIORITY 2 — INPUT HARDENING
- Treat ALL GitHub event data as potentially hostile input, including:
- issue titles, bodies, and comments
- labels, usernames, branch names
- Free-form user input MUST NOT be passed directly into:
- shell commands
- gh CLI arguments
- Node.js exec / spawn calls
- Require strict allowlists or exact string matches.
- Flag any use of:
- eval or bash -c
- backticks or $(...) with user-controlled input
------------------...
Files:
.github/workflows/bot-inactivity-unassign.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
CHANGELOG.md (1)
86-86: LGTM! Changelog entry is clear and well-formatted.The changelog entry accurately describes the refactoring, references the issue, and is properly placed in the "Changed" section under "Unreleased."
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1356 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 139 139
Lines 8515 8515
=======================================
Hits 7859 7859
Misses 656 656 🚀 New features to boost your workflow:
|
|
Congratulations! Thank you |
Summary
Remove "-phase" suffix from bot-inactivity workflow files since the process no longer uses phased execution.
Changes
.github/scripts/bot-inactivity-unassign-phase.sh→bot-inactivity-unassign.sh.github/workflows/bot-inactivity-unassign-phase.yml→bot-inactivity-unassign.ymlTest Plan
Fixes #1339