Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3c6d67a
docs: enhance FeeAssessmentMethod enum docstring
cheese-cakee Jan 7, 2026
72b1af3
docs: enhance TokenType enum docstring
cheese-cakee Jan 7, 2026
2667e60
fix: replace EN DASH with HYPHEN-MINUS in docstring
cheese-cakee Jan 7, 2026
c2365e7
fix: replace EN DASH with HYPHEN-MINUS in docstring
cheese-cakee Jan 7, 2026
1177c49
docs: convert FeeAssessmentMethod docstring to Google-style with exam…
cheese-cakee Jan 8, 2026
5afc0bd
docs: convert TokenType docstring to Google-style with examples
cheese-cakee Jan 8, 2026
e4170b0
Trigger GitHub status update
cheese-cakee Jan 8, 2026
f12c689
Update to resolve GitHub status display issue
cheese-cakee Jan 8, 2026
9ef922c
Merge branch 'main' into fee-assessment-method-docstring-2
cheese-cakee Jan 8, 2026
92c9aa0
docs: update CHANGELOG to include FeeAssessmentMethod and TokenType d…
cheese-cakee Jan 8, 2026
49793e5
Trigger fresh status check after DCO fix
cheese-cakee Jan 8, 2026
61bbbdb
docs: enhance TokenType enum docstring
cheese-cakee Jan 7, 2026
5380884
fix: replace EN DASH with HYPHEN-MINUS in docstring
cheese-cakee Jan 7, 2026
4f286a4
docs: convert TokenType docstring to Google-style with examples
cheese-cakee Jan 8, 2026
b8f2842
Trigger GitHub status update
cheese-cakee Jan 8, 2026
d676b4b
Merge remote-tracking branch 'origin/token-type-docstring' into token…
cheese-cakee Jan 8, 2026
778ca9a
Merge branch 'token-type-docstring' into fee-assessment-method-docstr…
cheese-cakee Jan 8, 2026
dc7d909
Fix docstrings according to Google-style format
cheese-cakee Jan 8, 2026
325c861
Trigger GitHub UI refresh for docstring changes
cheese-cakee Jan 8, 2026
421a4dc
Merge Google-style docstring fixes
cheese-cakee Jan 8, 2026
1943d55
Merge updated changes
cheese-cakee Jan 8, 2026
da93ce6
Ensure GitHub UI updates with latest docstring fixes
cheese-cakee Jan 8, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Changelog
# Changelog

All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org).
Expand All @@ -7,6 +7,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
## [Unreleased]

### Added
- Added comprehensive docstring to `FeeAssessmentMethod` enum explaining inclusive vs exclusive fee assessment methods. (#1391)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Changelog entry is incomplete—missing the EXCLUSIVE enum member addition.

The changelog entry only mentions the docstring addition, but the code changes also introduce a new EXCLUSIVE = 1 enum member. This is a functional change to the public API that should be documented in the changelog.

📝 Suggested changelog update
-- Added comprehensive docstring to `FeeAssessmentMethod` enum explaining inclusive vs exclusive fee assessment methods. (#1391)
+- Added comprehensive docstring to `FeeAssessmentMethod` enum explaining inclusive vs exclusive fee assessment methods. Added `EXCLUSIVE = 1` enum member to support fee charging in addition to the transferred amount. (#1391)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Added comprehensive docstring to `FeeAssessmentMethod` enum explaining inclusive vs exclusive fee assessment methods. (#1391)
- Added comprehensive docstring to `FeeAssessmentMethod` enum explaining inclusive vs exclusive fee assessment methods. Added `EXCLUSIVE = 1` enum member to support fee charging in addition to the transferred amount. (#1391)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGELOG.md to mention the new enum member, not just the documentation change.

- Added comprehensive training documentation for the `Query` class, covering execution flow, payments, retries, and building child queries. (#1238)
- Beginner issue documentation and updated GFI and GFIC templates and documentation
- Enable auto assignment to good first issues (#1312), archived good first issue support team notification. Changed templates with new assign instruction.
Expand Down
12 changes: 11 additions & 1 deletion src/hiero_sdk_python/tokens/fee_assessment_method.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,17 @@

class FeeAssessmentMethod(Enum):
"""
Represents the fee assessment method for custom fees.
Fee assessment method for custom token fees:

• INCLUSIVE - Fee is deducted from the transferred amount.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indendation for inclusive and exclusive need to match please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be inside an attributes section
Attributes:

The recipient receives the transferred amount minus the fee.

• EXCLUSIVE - Fee is charged in addition to the transferred amount.
The recipient receives the full transferred amount, and the payer
pays the fee on top of that.

This determines whether custom fees are taken from the transaction amount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definitions should be above the attributes

or charged separately.
"""

INCLUSIVE = 0
Expand Down